Add GitHub link to About page - #142
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bb7dc7af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added a bordered GitHub button to the About page on both platforms, linking to the project repository. The button sits after the version/copyright block, above the Transmission acknowledgment. The iOS button plays haptic feedback on tap, consistent with the existing Transmission link. Also removed a stale comment suffix in the macOS view.
The macOS About window previously used a hard-coded 320×400 frame that left no headroom for the new button; the height is now derived from content (
.frame(width: 320)with the existing.windowResizability(.contentSize)), so the window always fits its content exactly.Why
Surface the project's source repository directly in the app, matching the About page pattern used in ComputerSolitaire.
Validation
swiftlint lint --quietpasses with no outputgeneric/platform=macOS)generic/platform=iOS,CODE_SIGNING_ALLOWED=NO)UI Changes
Both About views gain a bordered "GitHub" button between the copyright line and the divider. Layout order on both platforms: version, copyright, GitHub button, divider, "Powered by Transmission". The macOS About window now sizes its height to content.