Skip to content

Store public Sparkle configuration in Info.plist - #138

Merged
austin-smith merged 2 commits into
mainfrom
allow-fork-pr-ci
Aug 12, 2026
Merged

austin-smith merged 2 commits into
mainfrom
allow-fork-pr-ci

Conversation

@austin-smith

@austin-smith austin-smith commented Aug 12, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Stored the public Sparkle feed URL and EdDSA public key directly in BitDream/Info.plist.
  • Removed the .xcconfig and local override system.
  • Removed the public Sparkle repository-variable dependency from pull request and release builds.
  • Kept the Sparkle private signing key in GitHub Secrets.
  • Updated the release workflow, release script, and documentation to use the tracked app configuration.

Why

The feed URL and public key are public app metadata and need to be available when fork pull requests build the app. Keeping them in tracked Info.plist makes the app configuration valid in every build and avoids maintaining duplicate values in GitHub variables.

Validation

  • Ran 223 macOS tests successfully.
  • Built the iOS app successfully.
  • Built the macOS Release configuration successfully.
  • Verified the built macOS app contains the expected feed URL and a valid 32-byte public key.
  • Ran SwiftLint successfully.
  • Validated the workflow YAML, plist, release script syntax, and Git diff.

@austin-smith
austin-smith marked this pull request as ready for review August 12, 2026 05:17
@austin-smith austin-smith changed the title Allow CI without Sparkle configuration Store public Sparkle configuration in Info.plist Aug 12, 2026
@austin-smith

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 2ec10d6414

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@austin-smith
austin-smith merged commit 602df78 into main Aug 12, 2026
3 checks passed
@austin-smith
austin-smith deleted the allow-fork-pr-ci branch August 12, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant