Size settings window to content and make tabs scrollable - #131
Merged
austin-smith merged 3 commits intoAug 12, 2026
Merged
Conversation
tomholford
marked this pull request as ready for review
August 7, 2026 15:47
settings tabs claimed unbounded height via maxHeight infinity and trailing spacers, so the settings window opened at full screen height regardless of content. size the window to content, wrap each tab in a scroll view for short screens, and keep a minimum window height.
tomholford
force-pushed
the
size-settings-window-to-content
branch
from
August 9, 2026 20:02
733f479 to
f4d1f93
Compare
austin-smith
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
maxHeight: .infinityframes and trailingSpacer()s that made every macOS settings tab vertically greedy (macOSSettingsView.swiftSettingsServerTab,macOSGeneralSettingsTab.swift)ScrollViewwith.scrollBounceBehavior(.basedOnSize)so tabs taller than the screen scroll instead of clipping.windowResizability(.contentSize)andminHeight: 320so the window hugs content but can't collapseContentUnavailableView) keeps a 250pt minimum height instead of filling the windowWhy
The Settings window opened at full screen height regardless of tab content because the tabs reported unbounded ideal height. With sizing fixed, long tabs (e.g. General on smaller displays) also needed scrolling, since content taller than the screen was clipped with no way to reach it.
Preview
Before
Static image: Settings > General overflowed off screen, not scrollable
After
Video capture: Settings > General content is scrollable
bitdream-settings.mov
Validation
xcodebuild, signing disabled locally)swiftlint lint --quietcleanSettingsServerTabwrapper as the verified disconnected state.Disclosure
Claude Fable & Grok 4.5 were used in the research, design, implementation, and testing of this PR. I steered and provided feedback and changes as necessary.