Use native Liquid Glass for sidebar footer buttons - #129
Merged
Conversation
The footer circle buttons faked glass with a tertiarySystemBackground circle and manual shadow under buttonStyle(.plain), which suppressed all press feedback. Replace with glassEffect(.regular.interactive()) in a circle at 44pt to match native toolbar button metrics, wrapped in a GlassEffectContainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar footer buttons (Manage Servers, Settings) had no press feedback and didn't behave like native glass buttons. The "glass" was a hand-painted
Circle().fill(Color(.tertiarySystemBackground))with a manual drop shadow, and.buttonStyle(.plain)opted out of all system press feedback — so taps were visually dead.Fix
Replace the fake material with the native Liquid Glass API:
.glassEffect(.regular.interactive(), in: .circle)on a 44×44 label —.interactive()provides the native press shimmer/scaleGlassEffectContainerper Apple guidance for multiple glass elementsThe 44pt explicit size matches system toolbar item metrics (the main view's bottom-bar buttons), since standalone glass button styles don't hit that metric at any control size (regular ≈ 32pt, large ≈ 50pt).
Verification
Built and ran on an iPhone 17 Pro simulator (iOS 26.5), screenshotted the open drawer, and measured cropped regions: footer buttons and the native bottom-bar filter button both measure ~130px (≈44pt @3x) with matching icon proportions.