Polish drawer open state and transition - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
geometryGroup(). Previously the scrim was inserted structurally when the drawer opened, which rendered it at the animation's destination while the card slid underneath, producing visibly detached layers mid-transition.Color(white: 0.2)at the same 55% strength as light mode) that lifts the card to an elevated surface and dims its content in a single overlay.Why
The initial drawer implementation shipped with a broken open/close transition and a dark-mode open state that lost all layer separation. These were found while comparing both appearances against the design target after merge.
Validation
UI Changes
Drawer open state only: dark mode gains an elevated-gray card veil instead of a black dim, light mode top-bar glyphs ghost while open, and the open/close animation no longer shows detached layers.