Service messages #73

werwurm · 2025-09-03T05:15:48Z

Implements marshalling and unmarshalling for DICE service messages using
CBOR encoding.

Copilot

Pull Request Overview

This PR implements CBOR marshalling and unmarshalling for DICE service messages, establishing the message format and serialization layer for NAT20 service communication. The implementation adds support for various DICE operations including CDI promotion, certificate issuance, and cryptographic signing through a well-defined API.

Defines comprehensive message structures for all supported DICE operations
Implements CBOR encoding/decoding with proper error handling and validation
Provides extensive test coverage for round-trip serialization scenarios

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`include/nat20/service/messages.h`	Defines message structures and API for DICE service operations
`src/service/messages.c`	Implements CBOR marshalling/unmarshalling with validation logic
`src/service/messages.cddl`	CDDL specification documenting the CBOR message format
`src/service/test/messages.cpp`	Comprehensive test suite covering serialization round-trips and edge cases
`src/service/test/test.cpp`	Basic test runner for the service module
`include/nat20/error.h`	Adds new error codes for message parsing and validation
`CMakeLists.txt`	Integrates service library and tests into build system
`.github/license-check/license-config.json`	Adds license checking for CDDL files
`.github/license-check/header-apache2-semicolon.txt`	License header template for CDDL files

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-03T05:48:44Z

src/service/test/test.cpp

+
+int main(int argc, char *argv[]) {
+    ::testing::InitGoogleTest(&argc, argv);
+    std::cout << "Testing libnat20 service..." << std::endl;


The string 'libnat20' should be 'Libnat20' to match the project naming convention seen elsewhere in the codebase.

Suggested change

std::cout << "Testing libnat20 service..." << std::endl;

std::cout << "Testing Libnat20 service..." << std::endl;

src/service/messages.c

include/nat20/error.h

include/nat20/service/messages.h

src/service/messages.c

src/service/test/messages.cpp

src/service/test/test.cpp

Implements marshalling and unmarshalling for DICE service messages using CBOR encoding.

…cter.

Move certificate format enum to nat20/constants.h

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/service/messages.c

seidelrj · 2025-09-19T17:25:38Z

src/service/messages.c

+
+n20_error_t n20_msg_promote_request_read(n20_istream_t *istream,
+                                         n20_msg_promote_request_t *request) {
+


missed this nit.

seidelrj · 2025-09-19T17:28:00Z

src/service/messages.c

+
+n20_error_t n20_msg_issue_cdi_cert_request_read(n20_istream_t *istream,
+                                                n20_msg_issue_cdi_cert_request_t *request) {
+


missed this nit.

seidelrj · 2025-09-19T17:29:11Z

src/service/messages.c

+
+n20_error_t n20_msg_issue_eca_ee_cert_request_read(n20_istream_t *istream,
+                                                   n20_msg_issue_eca_ee_cert_request_t *request) {
+


missed this nit.

src/service/messages.c

…ssages

Enable annotations only in the library under test to avoid overwriting data with results from different tests.

github-actions · 2025-09-20T05:50:38Z

LCOV of commit `1721d1c` during lcov-test-coverage-report #36

Summary coverage rate:
  lines......: 96.1% (2420 of 2517 lines)
  functions..: 99.5% (194 of 195 functions)
  branches...: 87.2% (1372 of 1573 branches)

Files changed coverage rate: n/a

src/service/test/messages.cpp

…ssages

werwurm requested a review from Copilot September 3, 2025 05:16

This comment was marked as outdated.

Sign in to view

werwurm requested review from Copilot and seidelrj September 3, 2025 05:47

Copilot AI reviewed Sep 3, 2025

View reviewed changes

seidelrj requested changes Sep 3, 2025

View reviewed changes

werwurm added 5 commits September 10, 2025 09:22

Service messages

0e509ec

Implements marshalling and unmarshalling for DICE service messages using CBOR encoding.

Add licence check of cddl files which use semicolons as comment chara…

cd2c431

…cter.

fix silently skipping non existing map items

08d1baf

Add NAT20_STATELESS_MAX_PATH_LENGTH variable to cmake config.

d99d9f5

Move certificate format enum to nat20/constants.h

Address comments and tidy up the message map lables.

eeb91ba

werwurm force-pushed the werwurm/cbor_parser branch from 96ca001 to 088e415 Compare September 10, 2025 18:13

werwurm force-pushed the werwurm/service_messages branch from fb866a7 to eeb91ba Compare September 10, 2025 18:13

werwurm added 3 commits September 10, 2025 11:39

Merge branch 'werwurm/cbor_parser' into werwurm/service_messages

0e651f7

address more comments.

e52518d

Merge branch 'werwurm/cbor_parser' into werwurm/service_messages

dc8dd3c

werwurm requested review from Copilot and seidelrj September 10, 2025 19:01

Copilot AI reviewed Sep 10, 2025

View reviewed changes

src/service/messages.c Outdated Show resolved Hide resolved

src/service/messages.c Outdated Show resolved Hide resolved

werwurm added 2 commits September 10, 2025 13:54

nits

62363f4

add missing file contesnts.h

100628d

seidelrj requested changes Sep 19, 2025

View reviewed changes

werwurm added 5 commits September 19, 2025 17:54

Merge branch 'refs/heads/werwurm/cbor_parser' into werwurm/service_me…

f3419a7

…ssages

messages get slice error flow control

9a27501

Merge branch 'werwurm/cbor_parser' into werwurm/service_messages

8daa4af

Improve quality of test coverage measurements

981b588

Enable annotations only in the library under test to avoid overwriting data with results from different tests.

improve service messages test coverage

fd6f717

complete messages test coverage and fix some missing null pointer checks

20f9104

werwurm requested a review from seidelrj September 22, 2025 20:53

change error code numbering to harmonize with functionality

7c19cc3

seidelrj approved these changes Sep 23, 2025

View reviewed changes

src/service/test/messages.cpp Outdated Show resolved Hide resolved

werwurm added 6 commits September 23, 2025 20:30

address comments

099b1b5

Merge branch 'werwurm/cbor_parser' into werwurm/service_messages

cc0f221

address comments

9d1664f

Merge branch 'refs/heads/werwurm/cbor_parser' into werwurm/service_me…

50c15c2

…ssages

fix lint

6e415a3

Merge branch 'refs/heads/werwurm/cbor_parser' into werwurm/service_me…

1721d1c

…ssages

werwurm merged commit ee8e8ea into werwurm/cbor_parser Sep 25, 2025
7 checks passed

	std::cout << "Testing libnat20 service..." << std::endl;
	std::cout << "Testing Libnat20 service..." << std::endl;


		n20_error_t n20_msg_promote_request_read(n20_istream_t *istream,
		n20_msg_promote_request_t *request) {


		n20_error_t n20_msg_issue_cdi_cert_request_read(n20_istream_t *istream,
		n20_msg_issue_cdi_cert_request_t *request) {


		n20_error_t n20_msg_issue_eca_ee_cert_request_read(n20_istream_t *istream,
		n20_msg_issue_eca_ee_cert_request_t *request) {

Service messages #73

Service messages #73

Uh oh!

Conversation

werwurm commented Sep 3, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

seidelrj Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

seidelrj Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

seidelrj Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LCOV of commit 1721d1c during lcov-test-coverage-report #36

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 20, 2025 •

edited

Loading

LCOV of commit `1721d1c` during lcov-test-coverage-report #36