ci: harden release publish custody#11
Merged
Merged
Conversation
gchahal1982
force-pushed
the
codex/harden-release-publish-custody
branch
from
0514d04 to
249f0b5
Compare
Signed-off-by: gchahal1982 <108035922+gchahal1982@users.noreply.github.com>
gchahal1982
force-pushed
the
codex/harden-release-publish-custody
branch
from
491c237 to
b39ce03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/publish-update-manifest.shwith Cloudflare R2 bucket fallback andnpx wranglerfallbackWhy
The publish job downloaded artifacts but did not check out the repo before invoking
scripts/generate-checksums.sh, so a credentialed release could fail before publishing signed aggregate checksums. The release path also did not publish the Agent checksum manifest objects to the update bucket.Validation
bash -n scripts/publish-update-manifest.sh scripts/generate-checksums.sh scripts/sign-linux.sh.github/workflows/release.ymlgo run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/release.ymlWindows signing remains gated on the existing EV/PFX/HSM or managed signing provider secrets.