Conversation
auchri
requested changes
Apr 27, 2019
Owner
auchri
left a comment
auchri
left a comment
There was a problem hiding this comment.
Hi,
thank you for your PR :)
I think that won't work like that, because if the warning is added, the last modified time of the issue will be updated and because of that the issue won't be closed 30 days later.
I think a solution for this might be to not read the last modified time of the issue, but read each comment and exclude the ones from the autocloser. In this way the warning message won't impact the real time someone added a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code for the issue:
Feature Request: Warn before auto-closing #7
Fixes #7