Repository navigation
test(storage): separate cleanup progress from deadline coverage - #60
Merged
Merged
Conversation
AndroxxTraxxon
marked this pull request as ready for review
November 15, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI for the 0.11.0 candidate failed because the shared-log cleanup success test required
Progressunder the production 250 ms statement budget. The repository correctly reports a statement timeout asDeadlineDeferred, with acknowledged rollback and no physical-deletion authority; releasing the capture lock does not guarantee the next metadata statement meets that latency bound on a loaded runner.Give this correctness test explicit scheduling headroom (2-second statements, 4-second page), retaining ordinary nonqueued admission and every original lock-deferral, path and atomic-deletion assertion. Production defaults and repository code are unchanged.
Add a real PostgreSQL regression with an owned update trigger delayed by 350 ms. The unchanged default budget must produce SQLSTATE57014/DeadlineDeferred, acknowledge rollback, preserve the pending row/path and unclaimed evidence group, release admission and return no deletion path. With the delay still installed, a separately budgeted attempt must commit the fresh claim. No retries or skipped cases replace the assertions.
Status: ready for review and merge.
Validation: Rust formatting and diff checks passed. Owning Rust1.100 compilation and common lib/owning-test Clippy with -D warnings passed with zero compiler warnings. The complete storage-maintenance suite passed 44/44 with four threads on stock PG18, including the original failing case and controlled timeout/rollback/later-success regression. Local test profile opt0/debug0/jobs2 is recorded; normal CI retains its regular profile. Captured source inputs match the committed patch. Owned PostgreSQL container/anonymous volume absence independently verified, exact owned target removed after successful checks; logs and hashes retained. Runtime SQLx advisory-lock/CREATE/DROP DATABASE latency, no-transaction and connection-on-release notices are retained in the log; these are distinct from compiler warnings.
Astra: verified Codex/gpt-6-astra read-only review completed at exact e4c93df with no blocking defect. It confirmed nonqueued admission, preserved assertions and deletion-authority/rollback boundaries. This is test stabilization: neither the baseline failure nor the headroom positive rules out sustained production latency under the unchanged 250 ms budget. The timeout test proves PG57014 safe deferral, but does not independently prove trigger entry rather than an earlier protected statement timing out. These nonblocking limits remain explicit; repeated default-budget deferrals warrant separate liveness investigation. Reviewer did not execute tests, inspect CI or independently verify live cleanup.
Required CI complete at reviewed/tested head e4c93df: 15 successful checks, Release Configuration Checks skipped, no failures or pending checks. Mergeable against unchanged main58f55e4. After merge, the new main push CI must pass before a release decision. Original failed main log retained at
/tmp/attune-main-ci-0110-tests132845139114.log; reproduction/cleanup evidence under/tmp/attune-storage146-evidence/. No tag, release, dependency change, production budget increase or deployment.