Fix trending report order and add verbose mode #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a verbose mode, fixes the sorting order of the trending report, and corrects the reporter listing in the help message. - A `-v` or `--verbose` flag has been added to `dashboard.sh`. When used, it enables debug messages that show the script's execution flow. - The `reporters/trending.sh` script now sorts the 'Change' column numerically, correctly handling positive and negative values. - The `dashboard.sh` help message now only lists `.sh` files as available reporters, excluding other files like `README.md`.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This commit renames the `reporters` directory and functionality to `overviews` to avoid confusion with the `reports` directory. - The `reporters/` directory has been renamed to `overviews/`. - The command-line flag to run these scripts has been changed from `-r, --reporter` to `-o, --overview`. - All related documentation has been updated to reflect these changes.
This commit updates the README.md in the overviews/ directory to include a list of the current overviews and a short summary for each.
This commit addresses several issues found during PR review and testing: - The `dashboard.sh` script now provides a helpful message when a module produces no output, instead of failing silently. - The `test/dashboard.bats` test file has been updated to reflect the change from `reporters` to `overviews`. - Error handling in the `modules/crypto.sh` script has been improved to provide clearer messages when `bitcoin-cli` fails. - Flaky tests in `test/crypto.bats` have been stabilized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the sorting of the trending report, adds a verbose mode, and corrects the reporter listing.
PR created automatically by Jules for task 5359233296065081687