Skip to content

fix: reconcile stale deployment inventory - #104

Draft
zoeyrose wants to merge 5 commits into
mainfrom
fix/obsolete-metaserver-credential-inventory
Draft

zoeyrose wants to merge 5 commits into
mainfrom
fix/obsolete-metaserver-credential-inventory

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

Align deployment metadata with reviewed producer workflows so read-only manual-settings verification can proceed before Project synchronization.

Implementation / behavior

  • Remove retired ATRINIK_PRODUCTION_BUILDS_READ_TOKEN and ATRINIK_PRODUCTION_WRITER_FENCE_POLICY inventory entries. Preserve the current delivery-resource read token, deployment credentials, protected-branch policies, recovery key, and verification guards.
  • Update Classic's Pages activation marker to the official actions/deploy-pages@368f82528645a54fb793d4d04e342629a3f51346 (v5.0.1), already merged through Classic PR #547. The old marker incorrectly classified the existing Actions site as awaiting activation.
  • Update documentation and test fixtures; explicitly reject the obsolete credential and select DEV test records by identity.

Validation

The current metaserver source at 9f0d81b9a4b8df94f9f7fc5484f8f20ef4eee716 has no retired identifiers; both deployment workflows retain the delivery read token. Current Classic source and the official v5.0.1 tag match the updated marker. Refreshed with merged PR #105 (main aaae055) via clean merge 9f9c520. Configuration, shell syntax, ShellCheck and actionlint pass; all 29 policy/verifier shell tests pass. Exact-head CI is being checked. A fresh independent review of the refresh and semantic interaction with PR #105 found no defects. Independent reviews and final results are recorded in self-review receipts. The fresh read-only publisher plan completed and was inspected (eight proposed operations; none applied). Read-only manual verification still correctly stops at the existing production reviewer mismatch after retained credential and Classic Pages checks pass.

Limitations / follow-up

Keep draft pending both owner decisions: retain or remove the existing zoeyrose production environment reviewer, and review/accept the downstream Project mutation plan (43 planned changes at preparation) with automatic synchronization resumption on merge. This change performs no settings apply, Project synchronization, workflow dispatch, secret provisioning, or live Pages change. Correct Pages metadata does not prove a successful deployment; the latest performance workflow has a separate failure under investigation.

Intent brief

Goal: remove stale deployment inventory blockers using current reviewed source and live name/configuration evidence. Preserve all actual security and verification controls. Exclude broader rulesets/defaults drift, runtime repair, live operations, and Project reconciliation; these require separate coordination or owner approval.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@zoeyrose

Copy link
Copy Markdown
Member Author

Reviewed exact head 2b12b45d087d7eb59ffc06bac130eff694fd454c against main 9e5aa0cbeda41ac55307f712df8a42f6729a790e with fresh-context independent Astra reviewers.

The full review inspected all six changed files, affected credential schema and name-only verifier paths, current metaserver source, security/failure behavior, tests and documentation. Retained delivery read credentials, protected branches, recovery key and API failure checks are preserved. No workflow or Project mutation code changed.

Finding: P2 at tests/validate-manual-credentials.sh:259, stale numeric index made a negative DEV test a no-op. Fixed in 2b12b45d087d7eb59ffc06bac130eff694fd454c by selecting the exact development resource-read credential. Fresh-context delta review examined this fix and affected validator semantics with no further findings; full credential tests, selector identity assertion, bash syntax and diff check passed.

Validation so far: bin/validate, all shell syntax checks, targeted full credential test and git diff --check pass. Full policy suite remains running. Exact-head CI CodeQL and Dependency review pass; Policy validation remains running. Read-only bin/publish completed exit 0 and its unrelated drift was inspected, never applied. Read-only bin/verify-manual-settings accepts both retained credentials in both environments, then fails on existing unrelated Classic Pages activation/source drift. No credential values read or recorded.

Keep this PR draft pending owner review of the downstream Project plan (43 planned changes at preparation). No apply, Project synchronization, workflow dispatch, secret provisioning, live policy changes or merge authorized/performed.

@zoeyrose zoeyrose changed the title fix: remove obsolete metaserver credential inventory fix: reconcile stale deployment inventory Oct 31, 2026
@zoeyrose

Copy link
Copy Markdown
Member Author

Reviewed exact head d0075b8b4919b75be7c59d5c83c4b04a73169fdb against main 9e5aa0cbeda41ac55307f712df8a42f6729a790e.

Fresh-context independent Astra review covered the full initial six-file diff, affected schema/verifier, current metaserver workflows, security/failure behavior and docs/tests. One P2 stale numeric test index was fixed in 2b12b45d087d7eb59ffc06bac130eff694fd454c; fresh-context delta review confirmed exact DEV/name selection restores meaningful negative coverage, with no other findings.

A further fresh-context independent Astra review covered the final Pages delta 2b12b45..d0075b8, its four affected files, validator/verifier and failure fixtures, and supplied current Classic executable deployment step. No findings. Official actions/deploy-pages v5.0.1 resolves to the same full SHA as merged Classic PR547/current source. Existing identity, HTTPS, environment, source and credential controls remain intact; documentation separates metadata verification from deployment success.

Validation: all local tests/*.sh passed (the two changed Pages tests also passed in a separate final run); bin/validate, all shell syntax checks and git diff --check passed. Earlier exact-head hosted ShellCheck, CodeQL and Dependency review passed; final-head CI is pending. Full read-only publisher plan completed exit 0 and was inspected; unrelated policy drift remains unapplied. Final live manual verification passes retained credentials and the corrected Classic Pages check, then stops at pre-existing production required-reviewer drift. Live bin/audit cannot complete with this host's old gh (--slurp unsupported). These are reported limitations, not waived checks.

Keep draft pending owner review of the downstream Project plan (43 planned changes at preparation) and production environment drift. No apply, synchronization, workflow dispatch, secret provisioning, live policy/Pages changes or merge performed.

@zoeyrose

Copy link
Copy Markdown
Member Author

Reviewed exact head 23574220baab667cc403655b4b2f1971ab8277ff against main 9e5aa0cbeda41ac55307f712df8a42f6729a790e.

Fresh-context independent Astra review covered the full initial six-file diff, affected schema/verifier, current metaserver workflows, security/failure behavior and docs/tests. One P2 stale numeric test index was fixed in 2b12b45d087d7eb59ffc06bac130eff694fd454c; fresh-context delta review confirmed exact DEV/name selection restores meaningful negative coverage, with no other findings.

A further fresh-context independent Astra review covered the final Pages delta 2b12b45..d0075b8, its four affected files, validator/verifier and failure fixtures, and supplied current Classic executable deployment step. No findings. Official actions/deploy-pages v5.0.1 resolves to the same full SHA as merged Classic PR547/current source. Existing identity, HTTPS, environment, source and credential controls remain intact; documentation separates metadata verification from deployment success.

Validation: all local tests/*.sh passed (the two changed Pages tests also passed in a separate final run); bin/validate, all shell syntax checks and git diff --check passed. Fresh live checks on final head 2357422 pass: Policy validation (including ShellCheck and the full policy tests), CodeQL and all three analyses, Dependency review, and Conventional PR title. Full read-only publisher plan completed exit 0 and was inspected; unrelated policy drift remains unapplied. Final live manual verification passes retained credentials and the corrected Classic Pages check, then stops at pre-existing production required-reviewer drift. The initial audit attempt encountered the old host gh (--slurp unsupported); rerunning read-only bin/audit with an existing verified modern gh completed and reported 48 broader governance drift findings. No drift was applied. These are reported limitations, not waived checks.

Keep draft pending owner review of the downstream Project plan (43 planned changes at preparation) and production environment drift. No apply, synchronization, workflow dispatch, secret provisioning, live policy/Pages changes or merge performed.

Mechanical documentation delta d0075b8..2357422 independently reviewed: production count sentence now correctly says seven secrets and one variable, verified against config. No findings; diff check passed. No executable/configuration changes in this final delta, so prior local suite and live-plan evidence retain validity.

@zoeyrose

zoeyrose commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Reviewed exact head 9f9c5205a4610237619dbe264b57150723115622, cleanly merging main aaae055d390bb1e2ed8ab31aac7e4d57bdd85bdc (PR105), with previous reviewed PR head 23574220baab667cc403655b4b2f1971ab8277ff.

Fresh-context independent GPT-6.1 Sol high review examined the prior-head delta, complete six-file net cleanup, affected credential/environment/Pages validation, and semantic interaction with PR105 ruleset normalization, preservation, concurrency fences, audit integration, tests and documentation. No P0–P3 findings. There were no conflict resolutions or new authored code beyond the clean merge.

Validation: all 29 tests/*.sh pass; bin/validate, shell syntax and git diff --check pass. ShellCheck 0.11.0 and actionlint 1.7.12 pass in the cached immutable linux-build 1.18.0 container with read-only checkout and no network. Full read-only bin/publish plan completed and was inspected: eight proposed operations, none applied. Fresh read-only manual verification passes retained credentials and Classic Pages, then correctly fails on known production required-reviewer mismatch. Exact-head hosted checks are being verified separately.

Keep draft pending both owner decisions: adopt or remove the existing production zoeyrose reviewer, and review/authorize the 43 planned Project mutations and automatic synchronization resumption upon merge. No live apply, Project sync, secret provisioning, policy mutation, workflow dispatch or merge performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant