Repository navigation
ci: only fail pull requests on advisories they introduce - #74
Merged
Merged
Conversation
A RustSec advisory published against main's Cargo.lock failed every open pull request, including Dependabot updates that do not touch Rust. Pull requests now compare against the base revision and warn about advisories already present there; main pushes, local runs and dependency candidates stay strict, and a daily workflow reports advisories on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016FyuSKkineBeVKbubYFsqd
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
zoeyrose
marked this pull request as ready for review
October 17, 2026 14:19
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74ba4a61e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A cargo-deny run that failed without reporting advisories (a database fetch or metadata error) was read as no advisories. Treat a non-zero exit without a completed summary and findings as a failure, and key findings by crate coordinates so distinct yanked crates are not merged into one entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016FyuSKkineBeVKbubYFsqd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Zoey · project thread
Summary
Before: when a RustSec advisory was published against a crate already in
main'sCargo.lock,cargo deny checkfailed on every open pull request. #72 (a GitHub Actions bump) and #73 went red on RUSTSEC-2026-0346 through 0349 inrustls0.23.45 even though neither change caused them.After: pull requests fail only on advisories they introduce. Advisories already present on the base revision show up as warnings on the PR. Pushes to
main, localtools/validate.shruns and the released-dependency candidate stay strict, and a new dailyDependency advisoriesworkflow fails onmainso a new advisory is visible in one place instead of on every PR.How:
tools/check-advisories.shrunscargo deny check advisorieswith JSON output. WhenADVISORY_BASE_REVISIONis set, whichvalidate.ymldoes from the pull request's base SHA, it runs the same check in a temporary worktree at that revision and fails only on the advisory IDs the base does not have.validate.shkeeps running bans, licenses and sources directly.The
rustlsfix itself is on #72 and #73.Provenance and assets
Validation
tools/validate.sh(CI)tools/check-advisories.shlocally with pinned cargo-deny 0.20.2 in each mode: strict on currentmainexits 1; with base =mainit exits 0 and warns about the fourrustlsadvisories; withrustls0.23.46 it printsadvisories ok; with base = a fixed lockfile and head =main's lockfile it exits 1 and lists the four as introduced.Generated by Claude Code