Repository navigation
fix(ci): preserve performance site when GPU measurements are unavailable - #642
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
|
Fresh-context independent Astra review covered base 3206b6d through cc89c8a. Reviewed the complete five-file diff and affected benchmark producer, strict report validation, checkpoint construction/fetch, workflow permissions/concurrency and publication/alert failure paths, tests and docs. No actionable P0–P3 findings; no fixes or declined findings. Verified exact recognized GPU skip only suppresses publication, complete data retains strict validation, and successful no-op runs cannot masquerade as deployed predecessors. Predecessor lookup remains bounded and checks manifest run/attempt/SHA. Independent and implementer runs of 46 focused tests passed; import-history verification and diff check passed. Broad local tooling suite attempted (877 tests), but 104 cases errored because CMake is absent and one socket fixture was blocked by the local sandbox; this is not a broad local pass. Current-head CI supplies broad validation. No workflow rerun, Pages deployment, or hardware qualification was performed. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
The scheduled Classic benchmark currently emits an explicit GPU-qualification skip record. The Pages projection treated the record's existence as a complete measurement and failed schema validation.
Implementation / behavior
gpu-hardware-qualification-requiredskip as an unavailable observation; all other inputs retain complete-evidence validation.Validation
python3 tools/verify_import_history.py: five imported histories verified.git diff --checkpassed.Limitations / follow-up
This changes source orchestration only. It does not qualify GPU hardware, rerun the scheduled workflow, deploy Pages, change governance settings, or create new performance measurements. Existing published measurements remain unchanged when the benchmark is unavailable.