Repository navigation
Compose BetterEditor, fix editor gestures, and migrate workspace tooling - #431
Open
rmolinamir wants to merge 14 commits into
Open
rmolinamir wants to merge 14 commits into
rmolinamir wants to merge 14 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BetterEditor exports composable engine and React parts. Journl assembles its own editor, toolbar, block/context/table menus, and reference actions. The library has no application preset, UI-component injection, or services map.
devEngines.packageManager. NativeaddMissingPeerTypesreplaces the removed.pnpmfile.cjshook. Remove NVM configuration and the obsolete hoist exclusion; declare dependencies exposed by isolated installation.Distribution is intentionally future work. Source namespaces, relative internal imports, explicit leaf exports, and consumer-owned composition leave the way open for npm and shadcn distribution. The editor registry prototype, its test, generated assets, installation instructions, and all dev/build/test wiring have been removed. No registry is generated or hosted, and no packages were published.
The document/reference contracts remain. Further schema modularization, transaction-mapped indexes, bounded pointer hit testing, and AI replacement remain separate work. Architecture and validation notes are under
docs/editor-design/.Validation:
The requested global virtual-store default installs and typechecks. Current Workflow/Turbopack loaders cannot transform dependencies outside the project filesystem, so app development/builds and CI require
PNPM_VIRTUAL_STORE_TYPE=project. The README documents switching layouts. Builds used disposable fixture values, not production credentials. Benchmarks distinguish cached read/diff/commit delivery from full decoding and do not measure browser typing latency.Independent audit follow-up
A read-only subagent audited tooling, the original findings, and the agreed coding standards. It found two P2 defects: retained table actions could apply obsolete state/positions, and independently composed controls could mutate read-only editors. The corrections resolve current target state, subscribe menus independently, reject stale/readonly mutations, cancel pending gestures, and hide mutation handles. A second read-only review caught and verified corrections for destroy-event timing and cell-selection anchor changes. The unused pnpm metadata reader was removed from Next config.
No additional blocking tooling defect was found. This does not close every original design finding. Incremental document processing, broad subscriptions, gutter/reference fan-out, the engine/DOM presentation seam, optional feature splitting, and public export curation remain partial or open. See the full audit.
Correction validation passed 455 unit/UI tests, ten workspace typecheck tasks, lint, frozen installation, and an uncached Turbopack build. Related table/accessibility acceptance passed 15 tests across Chromium/WebKit with five platform skips. The final read-only handle regression then passed in both browsers. These are focused follow-up checks, not another complete browser/database sweep. Existing document/reference dependencies remain explicitly deferred.