Repository navigation
Trim editor controls to final acceptance requirements - #430
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rmolinamir
marked this pull request as ready for review
October 26, 2026 03:36
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 27, 2026 21:29
4468fed to
4331ff5
Compare
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 28, 2026 12:10
4331ff5 to
82de8d4
Compare
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 28, 2026 15:00
a8891c4 to
56243b1
Compare
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 28, 2026 15:16
56243b1 to
f77f95a
Compare
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
2 times, most recently
from
October 28, 2026 15:41
3ee252a to
fad2487
Compare
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 28, 2026 15:57
fad2487 to
fe74958
Compare
rmolinamir
enabled stacked auto-merge
October 28, 2026 16:04
rmolinamir
force-pushed
the
codex/editor-acceptance-cleanup
branch
from
October 28, 2026 16:05
fe74958 to
6d6c764
Compare
rmolinamir
disabled stacked auto-merge
October 28, 2026 16:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim editor controls to accepted interaction requirements and stabilize cross-platform browser acceptance, including remote downloads, native mobile selection, and resolved preview links.
Stacked on the preceding PR. Adapted to the single @acme/better-editor package: engine, UI, and serialization namespaces with explicit subpath exports. Document, reference, and shared UI packages remain separate.
Validation on the final stack: dependency checks, lint, workspace typechecks, unit tests, and all 43 database integration tests pass locally. A real shadcn installation and standalone TypeScript compile pass. Final local verification passed: 102 browser tests passed with 20 intentional browser-specific skips, and the Next.js 16.4.3 Turbopack production build passed using disposable fixture environment values. The mobile handle test now waits for paragraph splits before checking alignment. Cloud CI is blocked by the account billing limit. No packages were published.
CSS namespace follow-up: replace Journl-specific classes, custom properties, DOM data attributes, and matching selectors with BetterEditor names. Update color resolution, node views, hit-testing, clipboard markup, and tests together. Stored block types remain unchanged. Workspace typechecks, 93 editor tests, registry tests, and targeted formatting pass. A targeted handle browser run stopped on cold-server page navigation before editor assertions; all four standalone light/dark appearance checks passed in desktop Chromium and mobile WebKit; the Next.js Turbopack production build passed with disposable fixture environment values. Earlier full-suite results above precede this namespace change.
Internal-name cleanup: rename ProseMirror node/group names, extension names, plugin keys, and transaction metadata to BetterEditor names. Remove application wording and registry host defaults from package documentation; retain repository provenance. No callback/API redesign or document/reference dependency removal in this pass. Workspace typechecks, 93 editor tests, registry generation/tests, and package formatting pass after this cleanup; browser/build results above precede this internal rename.
Naming convention: BetterEditor is the product name; package/directory/registry names and CSS/DOM/plugin/metadata strings use better-editor kebab-case; schema and TypeScript symbols use betterEditor camelCase. Package is now @acme/better-editor at packages/better-editor. Frozen-lockfile install, dependency checks, workspace typechecks, 93 editor tests, registry tests, and formatting pass. Browser/build results above precede this naming-only follow-up.
Project renamed to BetterEditor: @acme/better-editor, packages/better-editor, better-editor registry/style/metadata names, and betterEditor internal symbols. The publishing scope remains provisional; nothing was published. Typechecks, 93 editor tests, registry tests, frozen-lockfile installation, dependency checks, and targeted formatting pass. Browser/build results above precede this naming-only rename.
Consumer-owned styling: move mobile toolbar ordering/sticky placement, application header/viewport offsets, editor font selection, and page spacing into apps/web/src/components/editor/document-editor.css, scoped to Journl’s connected editor. BetterEditor inherits fonts by default and keeps the toolbar in normal document flow; it does not read app-specific CSS variables. Verify this on every stack layer. Validation after this change: workspace typechecks, 93 editor tests, registry tests, six Chromium/WebKit appearance and neutral-consumer checks, and the Turbopack production build pass.