Skip to content

Fix touch drag ownership, mobile controls and table column reveal - #427

Merged
rmolinamir merged 3 commits into
mainfrom
codex/editor-touch-gesture-fixes
Oct 28, 2026
Merged

rmolinamir merged 3 commits into
mainfrom
codex/editor-touch-gesture-fixes

Conversation

@rmolinamir

@rmolinamir rmolinamir commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Fix touch drag ownership, mobile controls, and table-column reveal. Preserve the stale table-axis drop guard in BetterEditor’s engine so canceled gestures cannot become clipboard copies.

Stacked on the preceding PR. Adapted to the single @acme/better-editor package: engine, UI, and serialization namespaces with explicit subpath exports. Document, reference, and shared UI packages remain separate.

Validation on the final stack: dependency checks, lint, workspace typechecks, unit tests, and all 43 database integration tests pass locally. A real shadcn installation and standalone TypeScript compile pass. Final local verification passed: 102 browser tests passed with 20 intentional browser-specific skips, and the Next.js 16.4.3 Turbopack production build passed using disposable fixture environment values. The mobile handle test now waits for paragraph splits before checking alignment. Cloud CI is blocked by the account billing limit. No packages were published.

CSS namespace follow-up: replace Journl-specific classes, custom properties, DOM data attributes, and matching selectors with BetterEditor names. Update color resolution, node views, hit-testing, clipboard markup, and tests together. Stored block types remain unchanged. Workspace typechecks, 93 editor tests, registry tests, and targeted formatting pass. A targeted handle browser run stopped on cold-server page navigation before editor assertions; all four standalone light/dark appearance checks passed in desktop Chromium and mobile WebKit; the Next.js Turbopack production build passed with disposable fixture environment values. Earlier full-suite results above precede this namespace change.

Naming convention: BetterEditor is the product name; package/directory/registry names and CSS/DOM/plugin/metadata strings use better-editor kebab-case; schema and TypeScript symbols use betterEditor camelCase. Package is now @acme/better-editor at packages/better-editor. Frozen-lockfile install, dependency checks, workspace typechecks, 93 editor tests, registry tests, and formatting pass. Browser/build results above precede this naming-only follow-up.

Project renamed to BetterEditor: @acme/better-editor, packages/better-editor, better-editor registry/style/metadata names, and betterEditor internal symbols. The publishing scope remains provisional; nothing was published. Typechecks, 93 editor tests, registry tests, frozen-lockfile installation, dependency checks, and targeted formatting pass. Browser/build results above precede this naming-only rename.

Consumer-owned styling: move mobile toolbar ordering/sticky placement, application header/viewport offsets, editor font selection, and page spacing into apps/web/src/components/editor/document-editor.css, scoped to Journl’s connected editor. BetterEditor inherits fonts by default and keeps the toolbar in normal document flow; it does not read app-specific CSS variables. Verify this on every stack layer. Validation after this change: workspace typechecks, 93 editor tests, registry tests, six Chromium/WebKit appearance and neutral-consumer checks, and the Turbopack production build pass.

@rmolinamir
rmolinamir added this pull request to stack #425 October 25, 2026 15:12
@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
journl Ready Ready Preview Oct 28, 2026 4:26pm UTC

@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 834683d to e034e7f Compare October 25, 2026 15:26
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 6b4a7a1 to 7def26f Compare October 25, 2026 20:05
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 7def26f to 14ce471 Compare October 25, 2026 23:48
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 14ce471 to 083e73c Compare October 27, 2026 21:29
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 083e73c to 4c901de Compare October 28, 2026 12:10
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from 4c901de to ecd4de1 Compare October 28, 2026 15:00
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch 2 times, most recently from 4e5eadf to 314fcf8 Compare October 28, 2026 15:31
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch 2 times, most recently from 234c049 to d5ab938 Compare October 28, 2026 15:57
@rmolinamir
rmolinamir enabled stacked auto-merge October 28, 2026 16:04
@rmolinamir
rmolinamir force-pushed the codex/editor-touch-gesture-fixes branch from d5ab938 to 5e522a8 Compare October 28, 2026 16:05
stacked auto-merge was automatically disabled October 28, 2026 16:05

Auto-merge was disabled for another pull request in the stack

Base automatically changed from codex/editor-mobile-handle-anchoring to main October 28, 2026 16:05
@rmolinamir
rmolinamir merged commit 8f68504 into main Oct 28, 2026
6 of 8 checks passed
@rmolinamir
rmolinamir deleted the codex/editor-touch-gesture-fixes branch October 28, 2026 16:05

This branch was successfully deployed

1 active deployment
Preview — 5e522a82 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant