Skip to content

Restore mobile Add block and stabilize block handle positioning - #426

Merged
rmolinamir merged 1 commit into
mainfrom
codex/editor-mobile-handle-anchoring
Oct 28, 2026
Merged

rmolinamir merged 1 commit into
mainfrom
codex/editor-mobile-handle-anchoring

Conversation

@rmolinamir

@rmolinamir rmolinamir commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Keep mobile block controls visible and anchored during scrolling, with coverage for pointer focus and mobile handle placement.

Stacked on the preceding PR. Adapted to the single @acme/better-editor package: engine, UI, and serialization namespaces with explicit subpath exports. Document, reference, and shared UI packages remain separate.

Validation on the final stack: dependency checks, lint, workspace typechecks, unit tests, and all 43 database integration tests pass locally. A real shadcn installation and standalone TypeScript compile pass. Final local verification passed: 102 browser tests passed with 20 intentional browser-specific skips, and the Next.js 16.4.3 Turbopack production build passed using disposable fixture environment values. The mobile handle test now waits for paragraph splits before checking alignment. Cloud CI is blocked by the account billing limit. No packages were published.

CSS namespace follow-up: replace Journl-specific classes, custom properties, DOM data attributes, and matching selectors with BetterEditor names. Update color resolution, node views, hit-testing, clipboard markup, and tests together. Stored block types remain unchanged. Workspace typechecks, 93 editor tests, registry tests, and targeted formatting pass. A targeted handle browser run stopped on cold-server page navigation before editor assertions; all four standalone light/dark appearance checks passed in desktop Chromium and mobile WebKit; the Next.js Turbopack production build passed with disposable fixture environment values. Earlier full-suite results above precede this namespace change.

Naming convention: BetterEditor is the product name; package/directory/registry names and CSS/DOM/plugin/metadata strings use better-editor kebab-case; schema and TypeScript symbols use betterEditor camelCase. Package is now @acme/better-editor at packages/better-editor. Frozen-lockfile install, dependency checks, workspace typechecks, 93 editor tests, registry tests, and formatting pass. Browser/build results above precede this naming-only follow-up.

Project renamed to BetterEditor: @acme/better-editor, packages/better-editor, better-editor registry/style/metadata names, and betterEditor internal symbols. The publishing scope remains provisional; nothing was published. Typechecks, 93 editor tests, registry tests, frozen-lockfile installation, dependency checks, and targeted formatting pass. Browser/build results above precede this naming-only rename.

Consumer-owned styling: move mobile toolbar ordering/sticky placement, application header/viewport offsets, editor font selection, and page spacing into apps/web/src/components/editor/document-editor.css, scoped to Journl’s connected editor. BetterEditor inherits fonts by default and keeps the toolbar in normal document flow; it does not read app-specific CSS variables. Verify this on every stack layer. Validation after this change: workspace typechecks, 93 editor tests, registry tests, six Chromium/WebKit appearance and neutral-consumer checks, and the Turbopack production build pass.

@rmolinamir
rmolinamir added this pull request to stack #425 October 25, 2026 06:47
@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
journl Canceled Canceled Oct 28, 2026 4:15pm UTC

@rmolinamir rmolinamir changed the title Keep mobile block controls visible and anchored through scrolling Restore mobile Add block and stabilize block handle positioning Oct 25, 2026
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 6adff17 to f8680dc Compare October 25, 2026 07:13
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from f8680dc to c5d4c66 Compare October 25, 2026 07:39
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from c5d4c66 to 8d96708 Compare October 25, 2026 07:56
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 8d96708 to 4c0113f Compare October 25, 2026 13:47
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 4c0113f to 0274d49 Compare October 25, 2026 14:16
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 0274d49 to c6ece86 Compare October 25, 2026 15:26
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from c6ece86 to 0f884cb Compare October 25, 2026 20:05
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 0f884cb to de9bf22 Compare October 25, 2026 23:47
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from de9bf22 to 242474a Compare October 27, 2026 21:29
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 242474a to 4ead7d8 Compare October 28, 2026 12:10
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 4ead7d8 to dea2be9 Compare October 28, 2026 15:00
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from dea2be9 to 21b3059 Compare October 28, 2026 15:16
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch 2 times, most recently from 29806ac to 4a47886 Compare October 28, 2026 15:41
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from 4a47886 to f91d15f Compare October 28, 2026 15:57
@rmolinamir
rmolinamir enabled stacked auto-merge October 28, 2026 16:04
@rmolinamir
rmolinamir force-pushed the codex/editor-mobile-handle-anchoring branch from f91d15f to b7fc173 Compare October 28, 2026 16:05
stacked auto-merge was automatically disabled October 28, 2026 16:05

Auto-merge was disabled for another pull request in the stack

Base automatically changed from codex/blocknote-retirement-cleanup to main October 28, 2026 16:05
@rmolinamir
rmolinamir merged commit c040207 into main Oct 28, 2026
6 of 8 checks passed
@rmolinamir
rmolinamir deleted the codex/editor-mobile-handle-anchoring branch October 28, 2026 16:05

This branch was successfully deployed

1 active deployment
Preview — b7fc1734 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant