Skip to content

a11y: name the eight icon-only links, and make the a11y scan enforce it for <a> #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atomantic merged 1 commit into from
Sep 2, 2026
Merged

a11y: name the eight icon-only links, and make the a11y scan enforce it for <a> #5825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 183 additions & 13 deletions client/src/a11yConventions.test.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions client/src/components/brain/tabs/LinksTab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ export default function LinksTab({ onRefresh }) {
draggable={false}
className="p-1.5 text-gray-400 hover:text-port-accent transition-colors"
title="Open in new tab"
aria-label={`Open ${link.title || link.url} in a new tab`}
>
<ExternalLink size={14} />
</a>
Expand Down
1 change: 1 addition & 0 deletions client/src/components/media/MediaCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ function MediaCard({
download
className="shrink-0 px-1.5 py-1 bg-port-border hover:bg-port-border/70 text-white text-[10px] rounded flex items-center justify-center"
title="Download"
aria-label="Download"
>
<Download className="w-3 h-3" />
</a>
Expand Down
1 change: 1 addition & 0 deletions client/src/components/media/MediaLightbox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,7 @@ function SettingsPane({
<a
href={item.downloadUrl}
download
aria-label="Download"
className="flex items-center justify-center gap-1.5 px-2 py-1.5 text-xs bg-port-border hover:bg-port-border/70 text-white rounded"
>
<Download className="w-3.5 h-3.5" />
Expand Down
1 change: 1 addition & 0 deletions client/src/components/moodBoard/MoodBoardReferenceStrip.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export default function MoodBoardReferenceStrip({
target="_blank"
rel="noopener noreferrer"
title="Open board in new tab"
aria-label="Open board in new tab"
className="shrink-0 p-1 text-gray-400 hover:text-port-accent"
>
<ExternalLink className="w-3.5 h-3.5" aria-hidden="true" />
Expand Down
1 change: 1 addition & 0 deletions client/src/pages/Browser.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ export default function BrowserPage() {
download={file.name}
className="p-1.5 rounded-md text-gray-400 hover:text-white hover:bg-port-border/50 transition-colors"
title="Save to device"
aria-label={`Save ${file.name} to device`}
>
<Download size={16} />
</a>
Expand Down
2 changes: 2 additions & 0 deletions client/src/pages/Loras.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,7 @@ function LoraCard({ lora, onDelete, onMeasured, deleting, deleteConfirm }) {
rel="noopener noreferrer"
className="text-gray-400 hover:text-gray-200 p-1.5 rounded hover:bg-port-bg"
title="Open on Civitai"
aria-label="Open on Civitai"
>
<ExternalLink size={14} />
</a>
Expand All @@ -1268,6 +1269,7 @@ function LoraCard({ lora, onDelete, onMeasured, deleting, deleteConfirm }) {
rel="noopener noreferrer"
className="text-gray-400 hover:text-gray-200 p-1.5 rounded hover:bg-port-bg"
title="Open on HuggingFace"
aria-label="Open on HuggingFace"
>
<ExternalLink size={14} />
</a>
Expand Down
1 change: 1 addition & 0 deletions client/src/pages/Uploads.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ export default function Uploads() {
rel="noopener noreferrer"
className="p-2 text-gray-500 hover:text-port-accent transition-colors"
title="Download / View"
aria-label={`Download or view ${file.filename}`}
>
<Download size={18} />
</a>
Expand Down