fix: rebuild production UI during managed app updates - #5823
Merged
Conversation
Managed Update app pulled, installed, and restarted without building client/dist. For PortOS that left the install out of sync and required a second Reconcile just to rebuild the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed Update app (Apps → Git → Repository sources) pulled, installed dependencies, ran setup, and restarted — but it never rebuilt the production UI. For PortOS that left
client/distolder than the pulled UI source, so the install immediately reported Install out of sync and required a second Reconcile (which runsupdate.sh, includingnpm run build) plus another restart.The managed updater now rebuilds the production UI before restarting whenever the app has a
buildCommandor ascripts.buildentry, using the same allowlisted build-command parser as the dedicated Build action. The confirmation modal lists that rebuild step so the action matches what actually runs.Test plan
npx vitest run services/appUpdater.test.js(build before restart; package.json fallback; no invented build; disallowed command refused; Bun usesbun run build)npx vitest run src/components/apps/tabs/RepositorySourcePanel.test.jsx(modal lists the UI rebuild)buildCommandfails the update and does not restart