feat: exclude API-billed instances from federated usage totals - #5804
Merged
Conversation
Across Instances combined totals assume every machine rides the viewer's subscriptions. A per-row Subscriptions toggle marks an instance as paying API rates so it stays listed but drops out of the combined figures. The choice is machine-local (settings.usageApiBilledInstanceIds) and does not ride the usage digest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Across Instances card on the Usage page now lets you turn Subscriptions off for a federated instance that pays real API rates instead of riding this install's plans.
That instance stays listed (the spend is still real) but is left out of the combined fleet total, so an API-billed box no longer inflates the subscription-priced figure.
The choice is machine-local (
settings.usageApiBilledInstanceIds) — it is this install's view of which fleet members ride the plans, not a property of the instance itself — and does not ride the usage digest.Test plan
cd server && npx vitest run services/usageFleetBilling.test.js services/peerUsage.test.js routes/usage.test.jscd client && npx vitest run src/components/usage/FleetUsageCard.test.jsx src/pages/UsagePage.test.jsx