feat: vscodeExtension - #32
Conversation
tenedor
left a comment
tenedor
left a comment
There was a problem hiding this comment.
Mostly looks good. Take a look at my comments and let me know when I should take another look. Thanks!
| "private": true, | ||
| "version": "0.0.0", | ||
| "type": "module", | ||
| "workspaces": [ |
There was a problem hiding this comment.
I assume this workspaces property should be in the top-level package.json
| @@ -0,0 +1,24 @@ | |||
| # Logs | |||
There was a problem hiding this comment.
What a long gitignore! I assume you copied this from somewhere else, but we should avoid needing this kind of gitignore. Can you reduce this to just what you think we need right now? It looks to me like literally none of these ignores are needed right now.
| @@ -0,0 +1,2 @@ | |||
| media/webview-out/ | |||
There was a problem hiding this comment.
Is media/webiew-out necessary to ignore? I don't see it getting used.
| port: Number(webviewPort) || 3002 | ||
| }, | ||
| build: { | ||
| outDir: '../extension/media', |
There was a problem hiding this comment.
Nothing in webview should write files to extension.
Is vite used to build the webview?
| "@tailwindcss/vite": "^4.1.7", | ||
| "dotenv": "^16.5.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", |
There was a problem hiding this comment.
You should be able to remove the React dependencies here and below now that the top-level project uses React.
2 participants
This is a pull request with the extension code. It doesn't modify any of the existing code except for .gitignore and package.json.