test(coverage): reach full Python coverage - #63
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
===========================================
+ Coverage 96.99% 100.00% +3.00%
===========================================
Files 19 20 +1
Lines 1499 1596 +97
Branches 239 261 +22
===========================================
+ Hits 1454 1596 +142
+ Misses 29 0 -29
+ Partials 16 0 -16 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds focused tests for the remaining Python edge cases across versioning, airport handling, configuration, importers, models, Passport data preparation, and storage. It also brings
scripts/refresh_airline_codes.pyinto the configured coverage scope and tests its Wikidata transformation, CSV writing, reporting, and entrypoint behavior without network access.Why
The package had 29 uncovered lines plus partial branches, while the maintainer script was absent from the report entirely. This makes every measured Python statement and branch visible and exercised; browser execution of Passport's authored JavaScript is tracked separately in #62.
Checks
./venv/bin/ruff check .and./venv/bin/ruff format .pass./venv/bin/pytest -qpassesgh issue listfor open issues this change touchesTest plan
Ran
pytest -q --cov --cov-report=term-missing --cov-fail-under=100: 412 tests passed, with 1,596 statements and 522 branches at 100% coverage. Ran the complete pre-commit suite, including Ruff, Markdownlint, mdformat, YAML and JSON checks; every hook passed.