Fix compatibility with pytest-run-parallel and add free-threaded CI jobs#63
Merged
Conversation
… it has no free-threaded wheel and its sdist requires libhdf5-dev which CI does not install
eeb1750 to
340e541
Compare
Comment on lines
+34
to
+35
| - linux: py313t-test | ||
| - linux: py313t-test-parallel |
Contributor
There was a problem hiding this comment.
I'd suggest going straight to 314t here:
- 3.13t was always experimental
- cibuildwheel is currently sunsetting it so it seems unlikely that
tableswill ever support it
| gen_dir = os.path.join(tmpdir, 'reference') | ||
|
|
||
| # Generate the reference file first | ||
| code = subprocess.call( |
Contributor
There was a problem hiding this comment.
shouldn't this use the builtin pytester fixture instead ? https://docs.pytest.org/en/stable/reference/reference.html#std-fixture-pytester
It does require pytest>=6.2, which is very reasonable now IMO (6.2 came out in 2020)
| numpy | ||
|
|
||
| # tables limitation is until 3.9.3 is out as that supports ARM OSX. | ||
| # tables limitation is until 3.9.3 is out as that supports ARM OSX, and |
Contributor
There was a problem hiding this comment.
I don't think this additional comment is particularly helpful here; it'd be much more fitting in tox.ini
Comment on lines
+387
to
+388
| @pytest.hookimpl(hookwrapper=True) | ||
| def pytest_runtest_call(self, item): |
Contributor
There was a problem hiding this comment.
isn't this implementation now exactly equivalent to the default ?
Co-authored-by: Clément Robert <cr52@protonmail.com>
…the pytester fixture with a pytest 6.2 minimum, testing free-threaded Python 3.14 instead of 3.13, trimming the tables comment in setup.cfg, and dropping the redundant array interceptor hook
neutrinoceros
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, we can't run tests with pytest-run-parallel if those tests rely on pytest-arraydiff (which is used e.g. in reproject):
The fix here ensures we don't wrap the tests multiple times, and make sure we always pass output values through.
(Note: I pushed this to an upstream branch by mistake as this repo used to be under my user - will fix it for future)