PLX-261: pass workspace and deployment context to appConfig query and drop deprecated fields for Houston 2.0#2080
Open
Simpcyclassy wants to merge 7 commits intomainfrom
Open
Conversation
…rop deprecated fields for Houston 2.0
Coverage Report for CI Build 5Coverage remained the same at 39.388%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
…ppconfig-workspace-deployment-context
| func deploymentCreate(cmd *cobra.Command, out io.Writer) error { | ||
| if clusterID != "" { | ||
| appConfig, _ = houston.Call(houstonClient.GetAppConfig)(clusterID) | ||
| appConfig, _ = houston.Call(houstonClient.GetAppConfig)(houston.GetAppConfigRequest{ClusterID: clusterID}) |
There was a problem hiding this comment.
You should pass workspace whereever possible. The astro cli commands don't expect workspace to be passed and it is stored in the context. You can fetch it anywhere via the coalesceWorkspace() function. Please use it here and pass the workspace as well.
| } | ||
|
|
||
| appConfig, err := houston.Call(client.GetAppConfig)("") | ||
| appConfig, err := houston.Call(client.GetAppConfig)(houston.GetAppConfigRequest{}) |
There was a problem hiding this comment.
The caller of RegistryAuth function has the deployment object. You can pass all the details from the caller to RegistryAuth function and pass it appConfig.
karankhanchandani
requested changes
Apr 10, 2026
karankhanchandani
left a comment
There was a problem hiding this comment.
Added comments. Can you please check those?
Base automatically changed from
chore/remove-houston-airflow-deprecations
to
main
April 10, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version-gate the
appConfigGraphQL query for Houston 2.0 to pass workspace and deployment context for environment-specific feature flag overrides, and drop deprecated top-level fields now redundant withfeatureFlags.What changed:
2.0.0entry to theappConfigqueryListthat accepts optional$workspaceUuidand$deploymentUuidparameters and drops deprecated fields (manualReleaseNames,configureDagDeployment,nfsMountDagDeployment,manualNamespaceNames,hardDeleteDeployment,triggererEnabled)GetAppConfigto accept aGetAppConfigRequeststruct instead of a singleclusterIDstring (required byhouston.Call's single-arg generic constraint)What didn't change:
Flagsstruct) still worksGetAppConfigRequest{}🎟 Issue(s)
Related PLX-261
🧪 Functional Testing
astro deploy— verifyappConfigquery includesworkspaceUuidanddeploymentUuidand returns correct feature flagsclusterIdonly) and behavior is unchangedastro deployment update <id>— verifydeploymentUuidis passed toappConfigastro login— verify registry auth still works with emptyGetAppConfigRequest{}📸 Screenshots
N/A — no UI changes.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft