PLX-273: version-gate Houston airflow deprecations#2076
Open
Simpcyclassy wants to merge 3 commits intomainfrom
Open
PLX-273: version-gate Houston airflow deprecations#2076Simpcyclassy wants to merge 3 commits intomainfrom
Simpcyclassy wants to merge 3 commits intomainfrom
Conversation
Coverage Report for CI Build 0Coverage increased (+0.002%) to 39.388%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version-gates deprecated Houston API fields (
airflowVersion,airflowImages,airflowVersions,defaultAirflowImageTag) so the CLI remains compatible when Houston PR #2423 removes them.Changes:
DeploymentInfoRequestandDeploymentImageUpdateRequestfrom standalone GraphQL strings to version-gatedqueryListentries. The 1.0.1+ variants omit all deprecated airflow fields.GetDeploymentConfig()andUpdateDeploymentImage()to resolve the correct query viaGreatestLowerBound(version).AirflowVersionfromUpdateDeploymentImageResp(unused — the function discards the response).omitemptytoUpdateDeploymentImageRequest.AirflowVersionso it is not serialized when empty.TestUpdateDeploymentImageto use runtime-only mock data.Backward compatibility with older Houston versions is preserved — the pre-1.0.1 query entries still include all airflow fields.
🎟 Issue(s)
Related https://linear.app/astronomer/issue/PLX-273/deprecate-astroruntimeenabled
Related astronomer/houston-api#2423
🧪 Functional Testing
make test— all houston, software/deploy, software/deployment, and cmd/software tests pass.make lint— no new lint issues.airflowVersionfields (backward compat).📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft