Skip to content

PLX-273: version-gate Houston airflow deprecations#2076

Open
Simpcyclassy wants to merge 3 commits intomainfrom
chore/remove-houston-airflow-deprecations
Open

PLX-273: version-gate Houston airflow deprecations#2076
Simpcyclassy wants to merge 3 commits intomainfrom
chore/remove-houston-airflow-deprecations

Conversation

@Simpcyclassy
Copy link
Copy Markdown
Member

Description

Version-gates deprecated Houston API fields (airflowVersion, airflowImages, airflowVersions, defaultAirflowImageTag) so the CLI remains compatible when Houston PR #2423 removes them.

Changes:

  • Converted DeploymentInfoRequest and DeploymentImageUpdateRequest from standalone GraphQL strings to version-gated queryList entries. The 1.0.1+ variants omit all deprecated airflow fields.
  • Updated GetDeploymentConfig() and UpdateDeploymentImage() to resolve the correct query via GreatestLowerBound(version).
  • Removed AirflowVersion from UpdateDeploymentImageResp (unused — the function discards the response).
  • Added omitempty to UpdateDeploymentImageRequest.AirflowVersion so it is not serialized when empty.
  • Updated TestUpdateDeploymentImage to use runtime-only mock data.

Backward compatibility with older Houston versions is preserved — the pre-1.0.1 query entries still include all airflow fields.

🎟 Issue(s)

Related https://linear.app/astronomer/issue/PLX-273/deprecate-astroruntimeenabled
Related astronomer/houston-api#2423

🧪 Functional Testing

  1. make test — all houston, software/deploy, software/deployment, and cmd/software tests pass.
  2. make lint — no new lint issues.
  3. Against Houston < 1.0.1: CLI should use the old queries that include airflowVersion fields (backward compat).
  4. Against Houston >= 1.0.1: CLI should use the new queries that omit deprecated fields. Deploys (image push, BYO registry, dag-only) should succeed without errors.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@Simpcyclassy Simpcyclassy requested a review from a team as a code owner April 9, 2026 02:15
@Simpcyclassy Simpcyclassy requested a review from a team as a code owner April 9, 2026 02:22
@coveralls-official
Copy link
Copy Markdown

coveralls-official bot commented Apr 9, 2026

Coverage Report for CI Build 0

Coverage increased (+0.002%) to 39.388%

Details

  • Coverage increased (+0.002%) from the base build.
  • Patch coverage: 4 of 4 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 63194
Covered Lines: 24891
Line Coverage: 39.39%
Coverage Strength: 9.52 hits per line

💛 - Coveralls

@Simpcyclassy Simpcyclassy changed the title refactor: version-gate Houston airflow deprecations PLX-273: version-gate Houston airflow deprecations Apr 9, 2026
Copy link
Copy Markdown

@karankhanchandani karankhanchandani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@pgvishnuram
Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants