Skip to content

Verbosity flag provides no extra information (#1501) #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronidelacruz-astro wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Verbosity flag provides no extra information (#1501) #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90c5a41
Verbosity flag provides no extra information (#1501)
ronidelacruz-astro Oct 22, 2025
e682b58
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 22, 2025
1481e37
add logs
ronidelacruz-astro Oct 27, 2025
aa8832d
Merge branch 'fix-verbosity-issue' of github.com:astronomer/astro-cli…
ronidelacruz-astro Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cloud/workspace/workspace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/astronomer/astro-cli/context"
"github.com/astronomer/astro-cli/pkg/ansi"
"github.com/astronomer/astro-cli/pkg/input"
"github.com/astronomer/astro-cli/pkg/logger"
"github.com/astronomer/astro-cli/pkg/printutil"
)

Expand Down Expand Up @@ -54,13 +55,17 @@ func GetCurrentWorkspace() (string, error) {
func List(client astrocore.CoreClient, out io.Writer) error {
c, err := config.GetCurrentContext()
if err != nil {
logger.Debugf("Failed to get current context: %v", err)
return err
}
logger.Debugf("Current context - Organization: %s, Workspace: %s", c.Organization, c.Workspace)

ws, err := GetWorkspaces(client)
if err != nil {
logger.Debugf("Failed to fetch workspaces: %v", err)
return err
}
logger.Debugf("Successfully retrieved %d workspace(s)", len(ws))

tab := newTableOut()
for i := range ws {
Expand All @@ -71,6 +76,7 @@ func List(client astrocore.CoreClient, out io.Writer) error {

if c.Workspace == ws[i].Id {
color = true
logger.Debugf("Workspace '%s' (ID: %s) is the current workspace", name, workspace)
} else {
color = false
}
Expand Down
14 changes: 12 additions & 2 deletions cmd/root_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,18 @@ import (

// SetupLogging is a pre-run hook shared between software & cloud
// setting up log verbosity.
func SetupLogging(_ *cobra.Command, _ []string) error {
return softwareCmd.SetUpLogs(os.Stdout, verboseLevel)
func SetupLogging(cmd *cobra.Command, _ []string) error {
// This fixes an issue where the package variable may not be properly bound in some build environments
level := verboseLevel
if cmd != nil {
if flagValue, err := cmd.Flags().GetString("verbosity"); err == nil && flagValue != "" {
level = flagValue
} else if flagValue, err := cmd.Root().PersistentFlags().GetString("verbosity"); err == nil && flagValue != "" {
level = flagValue
}
}

return softwareCmd.SetUpLogs(os.Stdout, level)
}

// CreateRootPersistentPreRunE takes clients as arguments and returns a cobra
Expand Down
6 changes: 6 additions & 0 deletions software/workspace/workspace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/astronomer/astro-cli/config"
"github.com/astronomer/astro-cli/houston"
"github.com/astronomer/astro-cli/pkg/input"
"github.com/astronomer/astro-cli/pkg/logger"
"github.com/astronomer/astro-cli/pkg/printutil"
)

Expand Down Expand Up @@ -64,13 +65,17 @@ func Create(label, desc string, client houston.ClientInterface, out io.Writer) e
func List(client houston.ClientInterface, out io.Writer) error {
ws, err := houston.Call(client.ListWorkspaces)(nil)
if err != nil {
logger.Debugf("Failed to fetch workspaces: %v", err)
return err
}
logger.Debugf("Successfully retrieved %d workspace(s)", len(ws))

c, err := config.GetCurrentContext()
if err != nil {
logger.Debugf("Failed to get current context: %v", err)
return err
}
logger.Debugf("Current context - Workspace: %s", c.Workspace)

tab := newTableOut()
for i := range ws {
Expand All @@ -82,6 +87,7 @@ func List(client houston.ClientInterface, out io.Writer) error {

if c.Workspace == w.ID {
color = true
logger.Debugf("Workspace '%s' (ID: %s) is the current workspace", name, workspace)
} else {
color = false
}
Expand Down