Fail explicit config writes when AF_CONFIG is non-regular#217
Open
RitwijParmar wants to merge 1 commit into
Open
Fail explicit config writes when AF_CONFIG is non-regular#217RitwijParmar wants to merge 1 commit into
RitwijParmar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigManager.require_writable()guard that preserves neutralized-config read/no-op behavior while giving explicit config mutations a clear failure path.af instance add/use/delete/reset, instance discovery write preflight, andaf telemetry enable/disable.AF_CONFIGas the platform-neutral stand-in for/dev/null.Fixes #194.
Verification
/Users/ritwij/Library/Python/3.9/bin/uv run pytest tests/test_cli_instances.py tests/test_cli_config_writes.py tests/test_layered.py tests/test_config.py(137 passed)/Users/ritwij/Library/Python/3.9/bin/uv run pytest tests --ignore=tests/integration(574 passed)/Users/ritwij/Library/Python/3.9/bin/uv run ruff check src tests/test_cli_instances.py tests/test_cli_config_writes.py tests/test_layered.py/Users/ritwij/Library/Python/3.9/bin/uv run ruff format --check src tests/test_cli_instances.py tests/test_cli_config_writes.py tests/test_layered.pyFull
pytestwas also attempted; onlytests/integration/test_api_endpoints.pyfailed because no Airflow server was listening onlocalhost:8080in my local environment.