Connect analyze-data skill to observe-mcp#157
Conversation
![astro-app-local[bot]](https://avatars.githubusercontent.com/in/792468?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary: Wires the analyzing-data skill to the Observe MCP server, documents an Observe-assisted vs SQL-only workflow, and removes the kernel ensure CLI command.
This is a plugin/skill repo change, not an Airflow DAG change, so the DAG checklist mostly doesn't apply. The diff is well-scoped and the SKILL.md restructuring reads cleanly. One concrete concern: the removed ensure command's docstring explicitly said "Used by hooks", and plugin.json still declares a SessionStart hook — if that hook invokes cli.py ensure, the hook now fails on every session start. I can't see the hook body from the diff alone, so worth confirming rather than blocking.
| @@ -216,29 +216,6 @@ def install_packages(packages: tuple): | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
The removed ensure command's docstring said "Used by hooks", and plugin.json still declares a SessionStart hook. If that hook still shells out to uv run scripts/cli.py ensure, every new session will now error with a Click "No such command 'ensure'" failure. Please confirm the hook command was updated in lockstep (or that nothing else in the plugin invokes ensure) — the hook body isn't in this diff.
| "description": "Data engineering plugin - warehouse exploration, pipeline authoring, Airflow integration", | ||
| "mcpServers": { | ||
| "observe": { | ||
| "type": "http", |
There was a problem hiding this comment.
http://localhost:8888/... assumes a local proxy is already running and pins the port. Worth documenting in the SKILL.md troubleshooting section (alongside the astro login note) what process is expected on :8888 and how a user starts it — otherwise the failure mode for "MCP not reachable" looks identical to "Observe not enabled" and the skill will silently fall back to SQL-only.
1 participant
No description provided.