Skip to content

feat!: remove ParametricExpressionSpec - #1277

Merged
MilesCranmer merged 2 commits into
astroautomata:masterfrom
MilesCranmerBot:agent/remove-parametric-expression-spec-v2
Aug 4, 2026
Merged

feat!: remove ParametricExpressionSpec#1277
MilesCranmer merged 2 commits into
astroautomata:masterfrom
MilesCranmerBot:agent/remove-parametric-expression-spec-v2

Conversation

@MilesCranmerBot

@MilesCranmerBot MilesCranmerBot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • remove ParametricExpressionSpec, its deprecation helper, exports, validation, and tests
  • remove the category arguments from fit and predict and the associated Julia extra-data path
  • keep the TemplateExpression category-indexed parameter example and pass category + 1 to Julia
  • document that PySR v2 cannot load saved ParametricExpressionSpec search states

Verification

  • pre-commit run --all-files
  • documentation generators and VitePress production build
  • git diff --check

Full tests and diff coverage run in repository CI. Rusty was offline during focused verification.

Release order

@MilesCranmerBot MilesCranmerBot mentioned this pull request Aug 3, 2026
Merged
@MilesCranmerBot
MilesCranmerBot force-pushed the agent/remove-parametric-expression-spec-v2 branch 2 times, most recently from d9e9718 to 37cb99d Compare August 3, 2026 18:46
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MilesCranmer
MilesCranmer marked this pull request as ready for review August 4, 2026 21:53
MilesCranmer
MilesCranmer requested changes Aug 4, 2026
View reviewed changes

@MilesCranmer MilesCranmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MilesCranmerBot please incorporate feedback

Comment thread CHANGELOG.md
Comment thread docs/src/options.md Outdated
@MilesCranmerBot @MilesCranmer
chore: drop changelog entry and v2 compat warning per review
0534032 
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@MilesCranmer
MilesCranmer merged commit d5f0bb0 into astroautomata:master Aug 4, 2026
23 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MilesCranmer MilesCranmer MilesCranmer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MilesCranmerBot @MilesCranmer