fix(release): recover partial immutable drafts#1286
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes immutable GitHub release publication resumable after an interrupted draft asset upload, ensuring previously uploaded assets are not replaced and that the final draft is fully re-authenticated before publication.
Changes:
- Add a recovery planner (
scripts/release_draft_recovery.py) plus tests to detect missing assets and validate any already-uploaded draft assets against the local candidate. - Update the release workflow to (a) always reconstruct and verify the signed candidate, (b) download and validate any existing draft assets, and (c) upload only missing assets sequentially.
- Update CI path filters and changelog entry to reflect the new recovery behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release_draft_recovery.py | New helper to validate existing draft assets and compute the minimal missing upload set without clobbering. |
| scripts/test_release_draft_recovery.py | Unit tests covering partial drafts, unexpected assets, byte mismatches, and symlink rejection. |
| .github/workflows/release.yml | Implements sequential recovery uploads and re-authentication of both local candidate and recovered remote asset contract. |
| scripts/test_channel_workflow_contract.sh | Extends workflow contract assertions to cover recovery script invocation and sequential upload behavior. |
| .github/workflows/ci.yml | Ensures CI runs and path filters include the new recovery script and its tests. |
| CHANGELOG.md | Documents the fix under [Unreleased]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1285
Summary
Make immutable release publication resumable after an interrupted asset upload without replacing any uploaded bytes.
Changes
Verification
python3 scripts/test_release_draft_recovery.pypython3 scripts/test_release_publication.pypython3 scripts/test_release_manifest.pybash scripts/test_channel_workflow_contract.shactionlint .github/workflows/release.ymlgit diff --checkChecklist
[Unreleased])