WIP Relay Collect (feature: WebRTC relaying of Collect Element to a second Asterics)#632
Open
WIP Relay Collect (feature: WebRTC relaying of Collect Element to a second Asterics)#632
Conversation
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-collect-transfer-relay/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-collect-transfer-relay/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-collect-transfer-relay/pr |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-collect-transfer-relay/pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! Warning: Just an experiment. Not aligned with a issue. Possibly completely useless (overlaps to an extent with Matrix integration). See also https://github.com/AceCentre/collect-transfer-relay which this PR uses
What this does:
So what if
This PR attempts to do this
In a second Instance of this PR - maybe on your phone, Copy the pairing token and URL.
Edit a grid's collect element And set "Whose messages to display" to Both or Partner.
Type your message on The first instance - see it show in the second. You can now make this second one just a Collect element etc
Status
Currently uses WebRTC. This means a signalling server connects to the two clients but then communication is entirely peer to peer. No data is transmitted to the server. (Except if you have a TURN server involved - which you may need to do for locked down envrionments)
Im not sure I like the UX. Its messy.
I think it should show somewhere the person is transmitting.
It needs a bit of a security audit