Conversation
…cause of `using` statement
| path, | ||
| home, | ||
| config: config_path, | ||
| timeout: Duration::from_millis(50), |
There was a problem hiding this comment.
Setting the timeout is 50ms will get nothing in comptest function.
Because
completest/crates/completest-pty/src/lib.rs
Line 495 in 4334bff
the read call is slow for powershell.
|
I've been working on test code to test support for PowerShell in I found a possibly related issue in the PowerShell community: PowerShell/PowerShell#14932 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Open the original file and read its content | ||
| let mut original_file = OpenOptions::new().read(true).open(&file_path)?; | ||
| let mut original_content = Vec::new(); | ||
| original_file.read_to_end(&mut original_content)?; |
Check failure
Code scanning / clippy
use of `File::read_to_end`
| // Open the original file and read its content | ||
| let mut original_file = OpenOptions::new().read(true).open(&file_path)?; | ||
| let mut original_content = Vec::new(); | ||
| original_file.read_to_end(&mut original_content)?; |
Check failure
Code scanning / clippy
use of `File::read_to_end`
Pull Request Test Coverage Report for Build 9790909347Details
💛 - Coveralls |
|
I have mixed feelings. Most devs will be on Linux so this makes it easy to not regress. However, most contributors to this feature will likely be on Windows and won't be able to test it.
sigh automatically closed issues. |
|
Most people definitely use PowerShell on Windows. Since I'm developing on Linux, my plan is to first support PowerShell on Linux to add tests for PowerShell support in clap_complete. I'll definitely need to support PowerShell on Windows later on. |
3 participants
To support powershell completion test