Skip to content

OUT-3229: realtime update for changes in CRM view #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandipBajracharya merged 1 commit into from
Mar 3, 2026
Merged

OUT-3229: realtime update for changes in CRM view #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions src/lib/realtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,24 @@ export class RealtimeHandler {
}
}

private isTaskShared(newTask: RealTimeTaskResponse): boolean {
return this.tokenPayload.clientId || !!getPreviewMode(this.tokenPayload)
? ((newTask.associations?.some(
(association) =>
(association.clientId === this.tokenPayload.clientId && association.companyId === this.tokenPayload.companyId) ||
(!association.clientId && association.companyId === this.tokenPayload.companyId),
) &&
newTask.isShared) ??
false)
: false
/**
* Check if the task is associated with the user or shared with the user
* If CRM view include association and shared. If CU view include only shared
*/
private isAssociatedOrShared(newTask: RealTimeTaskResponse): boolean {
const isPreviewMode = !!getPreviewMode(this.tokenPayload)
const isClientUser = this.tokenPayload.clientId && !isPreviewMode

if (isClientUser || isPreviewMode) {
const isRelatedTo = !!newTask.associations?.some(
(association) =>
(association.clientId === this.tokenPayload.clientId && association.companyId === this.tokenPayload.companyId) ||
(!association.clientId && association.companyId === this.tokenPayload.companyId),
)
return isClientUser ? isRelatedTo && !!newTask.isShared : isRelatedTo
}

return false
} //check if the task incoming from realtime includes the logged in client as a viewer.

/**
Expand Down Expand Up @@ -67,7 +75,7 @@ export class RealtimeHandler {
// Ignore all tasks that don't belong to client

if (
!this.isTaskShared(newTask) &&
!this.isAssociatedOrShared(newTask) &&
!(
(newTask.clientId == this.tokenPayload.clientId && newTask.companyId == this.tokenPayload.companyId) ||
(newTask.clientId == null && newTask.companyId == this.tokenPayload.companyId)
Expand Down Expand Up @@ -229,7 +237,7 @@ export class RealtimeHandler {
// - task is a client task, assigned to another client
// - task's companyId does not match current user's active companyId
if (
!this.isTaskShared(newTask) &&
!this.isAssociatedOrShared(newTask) &&
(!newTask.assigneeId ||
!!newTask.internalUserId ||
(newTask.clientId && newTask.clientId !== this.tokenPayload.clientId) ||
Expand Down Expand Up @@ -282,7 +290,7 @@ export class RealtimeHandler {
// --- Handle unassignment for clients (board + details page)
const isReassignedOutOfClientScope =
this.userRole === AssigneeType.client &&
!this.isTaskShared(updatedTask) &&
!this.isAssociatedOrShared(updatedTask) &&
(!updatedTask.clientId
? updatedTask.companyId !== this.tokenPayload.companyId
: updatedTask.companyId !== this.tokenPayload.companyId || updatedTask.clientId !== this.tokenPayload.clientId)
Expand Down Expand Up @@ -320,7 +328,7 @@ export class RealtimeHandler {
const isReassignedIntoClientScope =
this.userRole === AssigneeType.client &&
(updatedTask.assigneeId !== prevTask.assigneeId ||
this.isTaskShared(updatedTask) ||
this.isAssociatedOrShared(updatedTask) ||
(!updatedTask.clientId
? updatedTask.companyId === this.tokenPayload.companyId
: updatedTask.companyId === this.tokenPayload.companyId && updatedTask.clientId === this.tokenPayload.clientId))
Expand Down
Loading