Fix cached activity pruning after resumed Garmin backfills - #44
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
A Garmin backfill that resumes at a nonzero offset can finish scanning the remaining pages and then delete cached activities from earlier pages. Those IDs are absent from this run’s
fetched_ids, even though their activities still exist on Garmin.Only prune after a complete scan starting at offset zero, matching the protection already present in the Strava path. Normal complete-scan pruning and backfills restarted after a boundary change still work.
Validation:
On my host, three existing bootstrap tests fail because they expect GitHub CLI to be absent from
/usr/bin; the untouched base has the same failures. All pass in the clean container. Garmin responses were simulated; no live account was used.