Add low-level helpers Program::{draw_with, draw_elements_with}#565
Open
maxime-tournier wants to merge 3 commits intoasny:masterfrom
Open
Add low-level helpers Program::{draw_with, draw_elements_with}#565maxime-tournier wants to merge 3 commits intoasny:masterfrom
maxime-tournier wants to merge 3 commits intoasny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a small PR that factors out
Program::draw_*commonalities (setup/cleanup) into two new methods:draw_withanddraw_elements_with. These methods accept adrawcallback that is called between setup and cleanup, and are used to implement existingdraw_methods.Context: I need to implement some legacy
GL_LINESrendering and this is the smallest-yet-useful (hopefully!) set of changes I could come up with that allows me to do that. This means the two new methods must be public to be useful.Best regards,