Repository navigation
feat: Meetings page sort menu and filters panel (v4.3.0) - #13
Merged
Merged
Conversation
|
|
||
| function detectPlatform(url) { | ||
| if (!url) return null; | ||
| if (url.includes('meet.google.com')) return 'meet'; |
| function detectPlatform(url) { | ||
| if (!url) return null; | ||
| if (url.includes('meet.google.com')) return 'meet'; | ||
| if (url.includes('zoom.us') || url.includes('zoom.com')) return 'zoom'; |
| if (!url) return null; | ||
| if (url.includes('meet.google.com')) return 'meet'; | ||
| if (url.includes('zoom.us') || url.includes('zoom.com')) return 'zoom'; | ||
| if (url.includes('teams.microsoft.com') || url.includes('teams.live.com')) return 'teams'; |
| if (!url) return null; | ||
| if (url.includes('meet.google.com')) return 'meet'; | ||
| if (url.includes('zoom.us') || url.includes('zoom.com')) return 'zoom'; | ||
| if (url.includes('teams.microsoft.com') || url.includes('teams.live.com')) return 'teams'; |
…search capabilities
…nd new utility module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds sorting and filtering to the Meetings page. The UI follows DESIGN.md: hairline borders, pill controls, no shadows, ink chips for applied state.
Added
Changed
ui/Menu.jsx(Menu,MenuItem,MenuRadioItem,MenuLabel) used by both the sort menu and the existing Notion menu on a meeting page, so the two behave the same way with keyboard and mouse.renderer/lib/meetingFilters.jsas plain functions, separate from React (filterAndSort,statusCounts,hasActiveFilters,activeFilterCount,resolveDateRange).Docs
docs/ARCHITECTURE.md(renderer components,ui/,lib/) and the line inAGENTS.mdthat lists what the tests cover.Testing
pnpm run lintpasses.pnpm run testpasses, 110 tests including the meeting filter/sort tests.