Skip to content

Isolate component instances and finite progress values - #70

Merged
smiggleworth merged 1 commit into
mainfrom
fix/component-instance-isolation
Aug 16, 2026
Merged

Isolate component instances and finite progress values#70
smiggleworth merged 1 commit into
mainfrom
fix/component-instance-isolation

Conversation

@smiggleworth

@smiggleworth smiggleworth commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • key dismissable-layer registry state by component identity instead of caller-supplied IDs
  • preserve surviving layers when a same-ID sibling root unmounts
  • normalize all non-finite progress maxima to the documented default
  • add real-browser regression coverage

Validation

  • npm run check

Closes #68
Closes #69

@smiggleworth
smiggleworth marked this pull request as ready for review August 16, 2026 13:44
Copilot AI lite review requested due to automatic review settings August 16, 2026 13:44
Copilot AI reviewed Aug 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@smiggleworth
smiggleworth merged commit 19bc606 into main Aug 16, 2026
3 checks passed
@smiggleworth
smiggleworth deleted the fix/component-instance-isolation branch August 16, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Progress emits aria-valuemax="Infinity" for non-finite max values DismissableLayer instances collide on duplicate explicit IDs across roots

2 participants

@smiggleworth