Skip to content

Fix SQLite concurrency isolation - #20

Merged
smiggleworth merged 2 commits into
mainfrom
fix/sqlite-concurrency
Aug 16, 2026
Merged

Fix SQLite concurrency isolation#20
smiggleworth merged 2 commits into
mainfrom
fix/sqlite-concurrency

Conversation

@smiggleworth

@smiggleworth smiggleworth commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • serialize sibling nested SQLite transactions with context-scoped savepoint queues
  • share file-backed adapter queues by canonical database identity
  • release shared queue registrations when adapters close
  • cover recursive nesting and same-file multi-adapter overlap

Validation

  • npx vitest run src/sqlite.test.ts
  • npm run check

Closes #18
Closes #19

@smiggleworth
smiggleworth marked this pull request as ready for review August 16, 2026 13:44
Copilot AI lite review requested due to automatic review settings August 16, 2026 13:44
Copilot AI reviewed Aug 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@smiggleworth
smiggleworth merged commit d9a1cca into main Aug 16, 2026
4 checks passed
@smiggleworth
smiggleworth deleted the fix/sqlite-concurrency branch August 16, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Independent SQLite adapters can produce database locked errors Concurrent nested SQLite transactions corrupt savepoint state

2 participants

@smiggleworth