Run adapter conformance over real Node sockets - #24
Merged
Conversation
smiggleworth
marked this pull request as ready for review
August 15, 2026 20:42
11 tasks
Contributor
Author
|
Post-merge release audit: squash commit and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@askrjs/server/testingand run its shared conformance suite through real loopback socketsReadableStream.cancel()through the actual response writerhttp.Serverconstruction for bothlisten()andserve()Linked issue
Closes #23
Dependency
@askrjs/server@0.0.18TDD
1f92e83: the shared testing entry point was unavailable to the reference adapter.3a3e6a5: after adopting the released runner, real response cancellation passed but an incomplete chunked body exceeded the 2-second conformance deadline despite 100 ms timeout properties.03eaf42: request/header timeouts and a bounded checking interval are initialized at server construction; the real test passes in about 120 ms.Guardrails
listen()andserve()construct servers with enforceable optionsAcceptance audit
Verification
npm run checknpm audit --omit=dev