fix: authenticate Node client addresses - #22
Merged
Conversation
smiggleworth
marked this pull request as ready for review
August 15, 2026 19:47
Contributor
Author
|
Release closure verified:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLIENT_ADDRESS_HEADERcontractX-Forwarded-Foruntrusted and uninterpretedLinked issues
Closes #21
Prerequisite for askrjs/destroyer#10
TDD
af11bee: two real TCP requests rotate both spoofable headers and the app observes the attacker values.7cc10e1: the shared Node conversion boundary overwrites the reserved header withsocket.remoteAddresswhile leaving ordinary headers intact.Security boundary and guardrails
IncomingMessageto WebRequestconversionunknowncreateNodeHandler,listen, andserveall share the guarded conversion pathAcceptance audit
31904861365).@askrjs/node@0.0.11from exact squash merge1a635e5823dc8b861f9810b479d01fe42a0b93c4(run31904929419).Local verification
npm run checknpm audit --omit=dev