fix: reject stale concurrent add writes - #93
Merged
Conversation
smiggleworth
marked this pull request as ready for review
August 15, 2026 18:59
Contributor
Author
|
Release closure:
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
Closes #91
TDD
c640210: generic stale-write, concurrent page, concurrent action, and database-conflict regressions fail against the old implementation; both concurrent commands incorrectly return 0.1e7529c: expected-content transactions and add-command snapshots make the focused regressions pass.8730341: captures the action registries before descriptor discovery and deterministically protects that narrower interleaving.Guardrails
add pageandadd actionbarriers.env.exampleAcceptance audit
npm run check: 253 tests pass with coverage gates, plus lint, types, changelog, build, docs, publint, and package checks.@askrjs/cli@0.0.25from the exact squash merge.Local verification
npm run checknpm run test:templatesnpm run test:peer-floornpm run benchnpm audit