Repository navigation
docs: point the writing-skill references at clean-writing - #3
Merged
Merged
Conversation
The writing skill was renamed to clean-writing in protean-doctrine 2.0.0. Update the related_skills metadata in the draft-review skill and the rules note in the prose gate's module docstring so the reference resolves. Verified on the changed tree: the internal-names, prose, and renderer-defaults gates run clean, and python3 -m unittest discover -s tests passes (11 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the references at the writing skill's new name,
clean-writing, after its rename inprotean-doctrine2.0.0.Why
The old name no longer resolves to an installed skill, so both references dangled.
Changed paths
skills/draft-review-html/SKILL.md: therelated_skillslist. Frontmatter version to1.0.1.scripts/protean-drafts/check-prose.py: the rules note in the module docstring.protean-ingredient.jsonandinstall.sh: version to1.0.1.CHANGELOG.md: 1.0.1 entry.Dependency
Depends on the rename in aska-digital/protean-doctrine#11.
Validation
python3 gates/protean-drafts/check-internal-names.py .python3 scripts/protean-drafts/check-prose.py skills/draft-review-html/SKILL.mdpython3 gates/protean-drafts/check-renderer-defaults.py .python3 -m unittest discover -s testscontractfieldBase:
mainat44d485f. Checks run on the branch head,ffbdda7.