Implements supports_umbrella? callback#33
Conversation
|
Please let me know if there are any unit tests that we could add for this callback, in case that is not already covered by Igniter itself. |
|
🚀 Thank you for your contribution! 🚀 |
|
I'm trying to use this in an umbrella app and struggling a bit. I have installed from tip to get this change, but when I run from the root of the project, it only detects its own usage rules and doesn't pick up dependencies used by my subprojects (such as Phoenix used by Is this expected? |
|
🤔 Are you making multiple rules files? |
|
No. Just followed the most basic setup instructions. Added it as a dependency to my root umbrella project, then ran But just to be clear, phoenix isn't a direct dependency of the root project, only of one of the subprojects. |
|
🤔 I think all of the deps should be available in the root though 🤔 So it should work? I'd have to investigate and unfortunately I'm a bit busy at the moment. The task itself isn't too complex, happy to guide someone through the process of working it out. |
|
See #37 |
Contributor checklist
Leave anything that you believe does not apply unchecked.
Tested in a private umbrella app by running
mix igniter.install usage_rules@github:wigny/usage_rules@support-umbrellaand thenmix usage_rules.sync AGENTS.md --all.Closes #32.