fix(pds): detect did:web/did:plc repo DID mismatch after migration#199
Draft
zacbrown wants to merge 1 commit into
Draft
fix(pds): detect did:web/did:plc repo DID mismatch after migration#199zacbrown wants to merge 1 commit into
zacbrown wants to merge 1 commit into
Conversation
A repo lazily created under the `pds init` did:web default stays keyed to did:web after migrating the account to did:plc, since migrate skips repo import when blocks already exist. All checks passed but the relay rejected the repo at verifyRepoRoot and never onboarded the account. Fix 1: ensureRepoInitialized throws if loaded repo.did != env.DID. Fix 2: surface repo DID via checkAccountStatus + MigrationStatus and add checkRepoDidMatches to the activate preflight. Signed-off-by: Zac Brown <zacbrown@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repo lazily created under the
pds initdid:web default stays keyed to did:web after migrating the account to did:plc, since migrate skips repo import when blocks already exist. All checks passed but the relay rejected the repo at verifyRepoRoot and never onboarded the account.Fix 1: ensureRepoInitialized throws if loaded repo.did != env.DID.
Fix 2: surface repo DID via checkAccountStatus + MigrationStatus and add checkRepoDidMatches to the activate preflight.