Skip to content

Fix scale factor bug on Linux#503

Closed
swelljoe wants to merge 1 commit into
asb2m10:masterfrom
swelljoe:linux-macos-scale-factor-bug
Closed

Fix scale factor bug on Linux#503
swelljoe wants to merge 1 commit into
asb2m10:masterfrom
swelljoe:linux-macos-scale-factor-bug

Conversation

@swelljoe
Copy link
Copy Markdown

@swelljoe swelljoe commented Nov 24, 2025

I ran into this issue on Linux (Fedora 43, using Gnome on Wayland) using the Standalone Dexed version: #239

Issue was closed, but it seems to still be an existent bug on Linux. And, I think it also effects MacOS, based on the report and my understanding of the code.

As far as I can tell, this multiplication by display.scale is multiplying an already HiDPI scaled value, causing it to end up possibly several times the actual screen size. Making this change corrects it for me on Linux. I can't find anywhere this would cause problems, but I don't understand how plugins get sized and if this might somehow be breaking for that...I can load the VST into Carla and it looks fine (though it gets scale 1, while standalone version is scaled up to a more reasonable size).

I'll try to get access to a Windows machine to test on, if you want to ignore this PR for a while, but I figured I'd get it in front of you, as you may be able to spot why this has side effects I can't spot. This calculation must be there for some reason, but it definitely behaves badly on Linux with a HiDPI display.

I see you're also in the middle of some scaling work on this PR, so maybe that also corrects this problem in a different way, I dunno.

@swelljoe swelljoe changed the title Fix scale factor bug on Linux/MacOS Fix scale factor bug on Linux Nov 24, 2025
@asb2m10
Copy link
Copy Markdown
Owner

asb2m10 commented Nov 28, 2025

Thanks but I'm refactoring everything for scaling. That factor multiplication was introduced to fix #455, but that clearly didn't worked in the long run, I guess DAW might report different things... I'll just let the plugin scale and the user can switch back and not automate anything.

@asb2m10 asb2m10 closed this Nov 28, 2025
@asb2m10
Copy link
Copy Markdown
Owner

asb2m10 commented Nov 28, 2025

Btw, if you have time, can you test #505 on your setup, the scaling issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants