Fix scale factor bug on Linux#503
Closed
swelljoe wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks but I'm refactoring everything for scaling. That factor multiplication was introduced to fix #455, but that clearly didn't worked in the long run, I guess DAW might report different things... I'll just let the plugin scale and the user can switch back and not automate anything. |
Owner
|
Btw, if you have time, can you test #505 on your setup, the scaling issue should be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue on Linux (Fedora 43, using Gnome on Wayland) using the Standalone Dexed version: #239
Issue was closed, but it seems to still be an existent bug on Linux. And, I think it also effects MacOS, based on the report and my understanding of the code.
As far as I can tell, this multiplication by
display.scaleis multiplying an already HiDPI scaled value, causing it to end up possibly several times the actual screen size. Making this change corrects it for me on Linux. I can't find anywhere this would cause problems, but I don't understand how plugins get sized and if this might somehow be breaking for that...I can load the VST into Carla and it looks fine (though it gets scale 1, while standalone version is scaled up to a more reasonable size).I'll try to get access to a Windows machine to test on, if you want to ignore this PR for a while, but I figured I'd get it in front of you, as you may be able to spot why this has side effects I can't spot. This calculation must be there for some reason, but it definitely behaves badly on Linux with a HiDPI display.
I see you're also in the middle of some scaling work on this PR, so maybe that also corrects this problem in a different way, I dunno.