fix: configura autenticacao git no codenarc action para evitar erro 128#69
Merged
felipeeffting merged 3 commits intomainfrom Feb 4, 2026
Merged
fix: configura autenticacao git no codenarc action para evitar erro 128#69felipeeffting merged 3 commits intomainfrom
felipeeffting merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Review Summary
This PR configures Git authentication to resolve error 128 during git fetch operations. The implementation correctly checks for token presence and configures git to use it for HTTPS operations.
Critical Issue Found
- Security vulnerability: Current implementation embeds token in git config URL, which can leak in verbose output and error messages
Recommendation
Replace the URL rewrite approach with git credential helper to prevent token exposure in logs while maintaining the same functionality.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Contributor
|
🏷️ [bumpr] |
felipeeffting
approved these changes
Feb 4, 2026
Contributor
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacto
Configurada autenticação git no CodeNarc para resolver erro 128 que ocorria ao tentar fazer
git fetchsem credenciais. Ogithub_tokenjá era passado para o container, mas não estava configurado para operações git.Mudança:
Causa raiz: O token do GitHub era usado apenas para a API do reviewdog, mas não estava configurado para autenticação de operações git (fetch/pull). Com
fetch-depth: 2no checkout, commits mais antigos não estavam disponíveis localmente, causando falha ao tentar fetch.Cenários testados
https://github.com/asaasdev/asaas/pull/55852
https://github.com/asaasdev/asaas/actions/runs/21633090397/job/62354435129
https://github.com/asaasdev/asaas/pull/56274
https://github.com/asaasdev/asaas/actions/runs/21645188804/job/62395693545
Validação de retrocompatibilidade