fix: corrige falso positivo P1 causado por substring matching no grep#67
Merged
felipeeffting merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
Contributor
|
🏷️ [bumpr] |
felipeeffting
approved these changes
Jan 29, 2026
Contributor
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacto
Corrige bug que bloqueava PRs incorretamente com violacoes P1 em codigo legado nao modificado.
Causa raiz (2 bugs combinados):
grep -F "arquivo:22"dava match emarquivo:220,arquivo:224,arquivo:225+Solucao:
grep -F→grep -xF: Match exato de linha inteira (previne:22dar match em:220)+(codigo realmente adicionado)Problema:
Cenarios testados
Cenario 1: PR com P1 em codigo legado (linhas nao modificadas)
https://github.com/asaasdev/asaas/pull/56138
https://github.com/asaasdev/asaas/actions/runs/21439419412/job/61782060843?pr=56138
Cenario 2: PR com P1 em linha realmente modificada
https://github.com/asaasdev/asaas/pull/56169
https://github.com/asaasdev/asaas/actions/runs/21454044692/job/61790054958?pr=56169