[TEST] Missing error test for RequestException in ConnectWise API call#284
[TEST] Missing error test for RequestException in ConnectWise API call#284arumes31 wants to merge 1 commit into
Conversation
Implemented 9 unit tests in tests/test_cw_client.py to verify graceful handling of requests.exceptions.RequestException across all ConnectWiseClient methods. Verified: - find_open_ticket and create_ticket return None on error. - get_ticket and close_ticket raise appropriate custom exceptions (TicketNotFoundError/TicketRequestError). - add_ticket_note returns False on error. - List-fetching methods return an empty list [] on error. - Pre-commit checks (ruff, mypy) passed. Co-authored-by: arumes31 <114224498+arumes31@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Added comprehensive unit tests to
tests/test_cw_client.pyto coverRequestExceptionhandling inConnectWiseClientmethods. The tests ensure that methods return appropriate defaults (None,False, or[]) or raise custom exceptions as expected. This includes test coverage forfind_open_ticket,get_ticket,create_ticket,close_ticket,add_ticket_note, and severalget_*list methods. Verified all tests pass in the local environment and that linting/type-checking requirements are met.PR created automatically by Jules for task 8011933641485138359 started by @arumes31